Bug 16012 - The default authority type is not editable
Summary: The default authority type is not editable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: regression
Depends on: 15380
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-09 11:21 UTC by Jonathan Druart
Modified: 2016-12-05 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16012: Restore the ability to edit default authority type (3.77 KB, patch)
2016-03-09 11:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16012: Restore the ability to edit default authority type (3.83 KB, patch)
2016-03-09 15:52 UTC, Nick Clemens
Details | Diff | Splinter Review
[PASSED QA] Bug 16012: Restore the ability to edit default authority type (3.89 KB, patch)
2016-03-20 20:11 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-03-09 11:21:20 UTC
Bug 15380 introduced a regression on the authority types admin page: the default authority type (authtypecode="") is no longer editable.
Comment 1 Jonathan Druart 2016-03-09 11:22:53 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2016-03-09 15:52:32 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-03-20 20:11:07 UTC
Created attachment 49342 [details] [review]
[PASSED QA] Bug 16012: Restore the ability to edit default authority type

Bug 15380 introduced a regression on the authority types admin page: the
default authority type (authtypecode="") is no longer editable.

Test plan:
Edit the authority type to update the summary
=> Without this patch you will get the "add a new authority type" form
=> With this patch applied, the correct behavior will be restored

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-03-21 22:42:12 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-03-23 07:58:46 UTC
Does not concern stable versions, status changed to RESOLVED