Bug 16017 - Currency constraints and poorly named prices
Summary: Currency constraints and poorly named prices
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 13323 13726
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-09 12:53 UTC by Marcel de Rooy
Modified: 2016-08-22 08:17 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2016-03-09 12:53:52 UTC
Remainder from bug 15084:
Note that another report should deal with adding missing constraints on
the currency code in suggestions and aqbooksellers.
Also note that the aqorder fields listprice and invoiceprice refer to
currency. Imo these are very poor names for currency codes; you should
never call something a price when you mean a currency code!
Comment 1 Marcel de Rooy 2016-03-09 12:54:40 UTC
Jonathan: Can I please leave this one for you? :)
Comment 2 Jonathan Druart 2016-03-09 13:30:22 UTC
I can, but I won't now.
There are bug 13323 and bug 13726 in the queue.
Comment 3 Marcel de Rooy 2016-03-09 13:42:00 UTC
Just to abuse this report, to add something slightly related:

AqordersItem -- what should be the primary key? 
And why is itemnumber no FK ?
Comment 4 Jonathan Druart 2016-03-11 11:23:46 UTC
(In reply to Marcel de Rooy from comment #3)
> Just to abuse this report, to add something slightly related:
> 
> AqordersItem -- what should be the primary key? 

The PK is correct, it's itemnumber

> And why is itemnumber no FK ?

See bug 12555