Bug 16028 - Remove redundant hold links
Summary: Remove redundant hold links
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-09 16:01 UTC by Christopher Brannon
Modified: 2016-12-05 21:27 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Redundant hold links shown (50.22 KB, image/png)
2016-03-09 16:01 UTC, Christopher Brannon
Details
Bug 16028: Remove holds count from bibliographic information only (1.56 KB, patch)
2016-03-23 22:53 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16028: Remove holds count from bibliographic information only (1.66 KB, patch)
2016-03-24 00:42 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 16028: Remove holds count from bibliographic information only (1.67 KB, patch)
2016-03-24 06:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2016-03-09 16:01:31 UTC
Created attachment 48884 [details]
Redundant hold links shown

I would like to suggest that we remove some redundant hold links in the item record (detail.pl).  I've attached a screenshot showing that this page includes 3 links that ALL go to the same place.  I would like to suggest that the side tab and the count above the holdings be removed, and the button at the top be relabeled "View/Edit Holds", with a count next to it.

I think this would be worth the time, as having three links is a waste of space and code.  We don't need 3 ways to get to the same place.
Comment 1 Owen Leonard 2016-03-09 17:18:54 UTC
This case is unusual because holds can be considered both a "view" and an "action:"

https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions

I think redundancy is a small price to pay for consistency and clarity.
Comment 2 Christopher Brannon 2016-03-09 18:15:24 UTC
I think relabeling the button would bring enough clarity.

At the very least, I would dump the separate counter link, and have the count with one of the other links.
Comment 3 Katrin Fischer 2016-03-11 06:43:52 UTC
I think maybe we could remove the count from the bibliographic information as it always shows on the tab now. Otherwise I'd agree with Owen about keeping both the tab and the button.
Comment 4 Aleisha Amohia 2016-03-23 22:53:54 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2016-03-24 00:42:46 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2016-03-24 06:07:26 UTC
Created attachment 49511 [details] [review]
[PASSED QA] Bug 16028: Remove holds count from bibliographic information only

To test:

1) Go to the detail page for a record with holds (catalogue/detail.pl)
2) Confirm Holds count is no longer in bibliographic information but is
present in tab and Place Hold button is still on toolbar

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Brendan Gallagher 2016-03-24 17:19:03 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!