Bug 16040 - Quote deletion never ending processing
Summary: Quote deletion never ending processing
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL: /cgi-bin/koha/tools/quotes-upload.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-10 06:31 UTC by Frédéric Demians
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16040: Update fnReloadAjax DT plugin to fix quotes deletion (5.83 KB, patch)
2016-03-21 15:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16040: Update fnReloadAjax DT plugin to fix quotes deletion (5.98 KB, patch)
2016-03-21 17:14 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 16040: Update fnReloadAjax DT plugin to fix quotes deletion (6.05 KB, patch)
2016-03-23 22:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Demians 2016-03-10 06:31:51 UTC
In Tools > Edit Quotes, when deleting a quote, the message Processing is displayed endlessly. A JS error is visible:

dataTables.fnReloadAjax.js:12 Uncaught TypeError: this.oApi._fnServerParams is not a function
Comment 1 Marc Véron 2016-03-16 16:04:57 UTC
Confirmed. The quote is deleted, but you have to reload the page to display the table again.

See: http://datatables.net/plug-ins/api/fnReloadAjax
---snip---
DataTables 1.10 provides the ajax.url() and ajax.reload()
methods, built-in, to give the same functionality as this plug-in. As such
this method is marked deprecated, but is available for use with legacy
version of DataTables. Please use the new API if you are used DataTables 1.10
or newer.
---snip---

See Bug 12986 - Upgrade the DataTables jQuery plugin to the latest version
Comment 2 Jonathan Druart 2016-03-21 15:51:07 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-03-21 17:14:02 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2016-03-23 22:53:26 UTC
Created attachment 49485 [details] [review]
[PASSED QA] Bug 16040: Update fnReloadAjax DT plugin to fix quotes deletion

When deleting quotes, the table is not regenerated and a JS error is
raised.
That is because we are not using an up-to-date plugin

Test plan:
Delete a quote and confirm you do not get a JS error

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Brendan Gallagher 2016-03-24 15:32:17 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 6 Julian Maurice 2016-04-01 13:10:25 UTC
Patch pushed to 3.22.x, will be in 3.22.6
Comment 7 Frédéric Demians 2016-04-27 15:42:38 UTC
Pushed to 3.20.x, will be in 3.20.11.