Bug 16061 - Use Font Awesome icons in reports when filter returns no results
Summary: Use Font Awesome icons in reports when filter returns no results
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/reports/guided_reports.pl
Keywords:
Depends on:
Blocks: 16062
  Show dependency treegraph
 
Reported: 2016-03-14 13:38 UTC by Owen Leonard
Modified: 2017-06-14 22:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16061 - Use Font Awesome icons in reports when filter returns no results (2.92 KB, patch)
2016-03-14 13:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16061 - Use Font Awesome icons in reports when filter returns no results (3.02 KB, patch)
2016-03-14 16:45 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16061: Use Font Awesome icons in reports when filter returns no results (3.24 KB, patch)
2016-03-14 18:31 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-14 13:38:15 UTC
In Reports -> Saved reports, if you use the sidebar filter to submit terms for which there are no results a dialog is shown. This dialog should use Font Awesome icons.
Comment 1 Owen Leonard 2016-03-14 13:47:02 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-14 16:45:09 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2016-03-14 18:31:29 UTC
Created attachment 49146 [details] [review]
Bug 16061: Use Font Awesome icons in reports when filter returns no results

In Reports -> Saved reports, when the filter form returns no results a
dialog is shown. This patch updates the dialog to use Font Awesome
icons.

Also changed: The dialog now includes a button for creating a new SQL
report, not just one to create a new guided report. The "clear" link in
the sidebar has been modified to pass HTML validation.

To test, apply the patch and go to Reports -> Saved reports.

- In the left-hand sidebar filter, submit terms which will return no
  results.
- Verify that the resulting dialog is correctly styled.
- Confirm that all three buttons in the dialog work correctly: New
  guided report, new SQL report, and Cancel.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
I'm passing this one, while I don't like it is hardcoding a URL path,
because it will make is easier to spot it when time comes and we
make Koha delpoyable in any endpoint.
Comment 4 Brendan Gallagher 2016-03-21 21:31:53 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!