Bug 16099 - Make name required field when creating subscription field
Summary: Make name required field when creating subscription field
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-18 00:02 UTC by Aleisha Amohia
Modified: 2016-12-05 21:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16099: Make name required field when creating subscription field (1.39 KB, patch)
2016-03-18 00:06 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16099: Make name required field when creating subscription field (1.49 KB, patch)
2016-03-18 12:12 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 16099: Make name required field when creating subscription field (1.51 KB, patch)
2016-03-20 20:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-18 00:02:05 UTC
At the moment, it is required and doesn't allow the user to create the subscription field without entering the name, but it still lets the user submit the form to add a subscription field and then shows an error.
Comment 1 Aleisha Amohia 2016-03-18 00:06:06 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-03-18 12:12:36 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-03-20 20:58:29 UTC
Created attachment 49347 [details] [review]
[PASSED QA] Bug 16099: Make name required field when creating subscription field

To test:
1) Notice behaviour when adding subcription field (Serials) without a
   name
2) Apply patch
3) Attempt to create subscription field without a name and click Save
4) Notice that you not cannot submit the form without adding the name

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-03-23 00:38:46 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!