Bug 16109 - Toolbars wrapping on narrower browsers
Summary: Toolbars wrapping on narrower browsers
Status: RESOLVED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-19 03:28 UTC by Aleisha Amohia
Modified: 2023-09-09 18:11 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Buttons on members-toolbar.inc wrapping when I make my browser smaller (36.09 KB, image/png)
2016-03-19 03:28 UTC, Aleisha Amohia
Details
Bug 16109: Preventing toolbars from wrapping on staff client (961 bytes, patch)
2016-03-19 03:31 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16109: Preventing toolbars from wrapping on staff client (1.04 KB, patch)
2016-03-20 17:12 UTC, Mark Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-19 03:28:14 UTC
Created attachment 49326 [details]
Buttons on members-toolbar.inc wrapping when I make my browser smaller
Comment 1 Aleisha Amohia 2016-03-19 03:31:23 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-03-20 17:12:45 UTC
Created attachment 49335 [details] [review]
Bug 16109: Preventing toolbars from wrapping on staff client

To test:

1) Go to a members detail page
2) Notice wrapping of toolbar when making your browser window smaller
3) Apply patch
4) Confirm toolbar no longer wraps

Sponsored-by: Catalyst IT

NOTE: CSS files for intranet seem not to be less'd.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Jonathan Druart 2016-03-21 14:49:37 UTC
I'd say that the behavior before this patch is the expected one.
Owen could you please confirm?
Comment 4 Owen Leonard 2016-03-21 15:29:03 UTC
I think this may come down to a personal preference, which probably means that the proposed change belongs in IntranetUserCSS.

I don't think it looks beautiful when the toolbar buttons wrap, but I would prefer to have them wrap and be easily accessible rather than have to scroll horizontally to reach them.

Perhaps the question should be "Since the buttons wrap at smaller browser widths and it doesn't look great, how can we improve the appearance of the toolbar when the buttons /do/ wrap?" Solving that would bring us one small step closer to having a responsive staff client.
Comment 5 Katrin Fischer 2020-01-09 00:05:08 UTC
(In reply to Owen Leonard from comment #4)
> I think this may come down to a personal preference, which probably means
> that the proposed change belongs in IntranetUserCSS.
> 
> I don't think it looks beautiful when the toolbar buttons wrap, but I would
> prefer to have them wrap and be easily accessible rather than have to scroll
> horizontally to reach them.
> 
> Perhaps the question should be "Since the buttons wrap at smaller browser
> widths and it doesn't look great, how can we improve the appearance of the
> toolbar when the buttons /do/ wrap?" Solving that would bring us one small
> step closer to having a responsive staff client.

+1
Comment 6 Katrin Fischer 2023-09-09 18:11:12 UTC
The toolbar still wraps with the new staff design, but opposed to the old design the second line starts in the same position as the first one, giving it a cleaner look than in the old design. 

I also think that avoiding horizontal scrolling is good because I feel that it hurts usability.

I am closing this one out, please reopen if you disagree!