Bug 16137 - Simplify patron deletion error handling
Summary: Simplify patron deletion error handling
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL: /cgi-bin/koha/members/deletemem.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-23 18:22 UTC by Owen Leonard
Modified: 2020-01-11 14:36 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-23 18:22:20 UTC
When deleting a patron, there are some cases handled by deletemem.pl which stop the process and redirect to moremember.pl. Other cases stop the process and display an error in the deletemem.tt template.

Is there any reason not to redirect all deletion errors to moremember.pl and eliminate the need for deletemem.tt?
Comment 1 Katrin Fischer 2020-01-11 11:09:11 UTC
Hi Owen, can you tell if this is the case? Not sure what to exactly test here.
Comment 2 Owen Leonard 2020-01-11 14:36:17 UTC
Patron deletion errors/warnings handled by deletemem.pl:

 - Warning when you try to delete a patron with holds
 - Warning when you try to delete a patron with checkouts
 - Warning when you try to delete a patron with guarantees

Patron deletion errors/warnings handled by moremember.pl:

 - Unable to delete staff user
 - Not allowed to delete own account
 - Unable to delete patrons from other libraries with current settings
 - Unable to delete patron: Insufficient privileges