When searching for records via Z39.50 in Aquisitions the context menu links display the wrong records (probably the last one on the list). This was fixed by bug 15318 on master. But not backported as it is an enhancement.
Created attachment 49540 [details] [review] Bug 16146 - ACQ: Previewed records in Z39.50 search results are wrong For 3.22.x only: This patch fixes a bug which was fixed in cataloging by Bug 6367 and fixed in master by Bug 15318. A misplaced line of JavaScript means that the popup menu of options shown when clicking in a table cell links to the wrong record. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from an external source.. 4. Perform a search which will return multiple results. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 6. Click anywhere in the results table to show the hidden menu and test the "Preview MARC," "Preview card," and "Order" links it displays, confirming that the actions complete using the correct record.
Both MARC and Card look good on 3.22.x for me.
(In reply to Jonathan Druart from comment #2) > Both MARC and Card look good on 3.22.x for me. It's not the links in the last table cell in each row, but in the little menu which appears if you click within one of the other table cells.
Created attachment 49558 [details] [review] Bug 16146 - ACQ: Previewed records in Z39.50 search results are wrong For 3.22.x only: This patch fixes a bug which was fixed in cataloging by Bug 6367 and fixed in master by Bug 15318. A misplaced line of JavaScript means that the popup menu of options shown when clicking in a table cell links to the wrong record. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from an external source.. 4. Perform a search which will return multiple results. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 6. Click anywhere in the results table to show the hidden menu and test the "Preview MARC," "Preview card," and "Order" links it displays, confirming that the actions complete using the correct record. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Owen Leonard from comment #3) > (In reply to Jonathan Druart from comment #2) > > Both MARC and Card look good on 3.22.x for me. > > It's not the links in the last table cell in each row, but in the little > menu which appears if you click within one of the other table cells. Indeed! Sorry not to read commit messages with attention...
Created attachment 49566 [details] [review] [PASSED QA] Bug 16146 - ACQ: Previewed records in Z39.50 search results are wrong For 3.22.x only: This patch fixes a bug which was fixed in cataloging by Bug 6367 and fixed in master by Bug 15318. A misplaced line of JavaScript means that the popup menu of options shown when clicking in a table cell links to the wrong record. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from an external source.. 4. Perform a search which will return multiple results. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 6. Click anywhere in the results table to show the hidden menu and test the "Preview MARC," "Preview card," and "Order" links it displays, confirming that the actions complete using the correct record. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to 3.22.x, will be in 3.22.6. Thanks everyone