Bug 16147 - OpacItemLocation and not for circulation Item types
Summary: OpacItemLocation and not for circulation Item types
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-24 21:02 UTC by Ed Veal
Modified: 2020-11-30 21:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Veal 2016-03-24 21:02:05 UTC
If you set the OpacItemLocation to anything other than "Call number only" the call number is repeated on the Location line for all items with item types that don't circulate. 

<xsl:if test="items:itemcallnumber != '' and items:itemcallnumber and $OPACItemLocation='callnum'"> [<span class="LabelCallNumber">Call number: </span><xsl:value-of select="items:itemcallnumber"/>]</xsl:if>

<xsl:if test="items:itemcallnumber != '' and items:itemcallnumber"> [<span class="LabelCallNumber">Call number: </span><xsl:value-of select="items:itemcallnumber"/>]</xsl:if>

Ed
Comment 1 Katrin Fischer 2020-01-11 11:13:44 UTC
I am not sure what the described issue here is. Linking to a more recent OpacItemLocation bug. Owen, do you have an idea?
Comment 2 Owen Leonard 2020-01-11 14:43:00 UTC
Assuming you see the call number at all (see Bug 24352), I think this is the display that is intended by the design of the preference. I agree however that it probably isn't the best way to display the information.
Comment 3 Katrin Fischer 2020-01-19 21:54:50 UTC
(In reply to Owen Leonard from comment #2)
> Assuming you see the call number at all (see Bug 24352), I think this is the
> display that is intended by the design of the preference. I agree however
> that it probably isn't the best way to display the information.

Shoudl we close?
Comment 4 Ed Veal 2020-01-21 18:04:10 UTC
I am ok with this bug being closed. I think it is an old issue that has evolved since my original submission is not a big deal. 

Ed
Comment 5 Katrin Fischer 2020-03-15 17:36:25 UTC
(In reply to Ed Veal from comment #4)
> I am ok with this bug being closed. I think it is an old issue that has
> evolved since my original submission is not a big deal. 
> 
> Ed