Bug 16164 - Making check expiration actions buttons
Summary: Making check expiration actions buttons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-30 00:01 UTC by Aleisha Amohia
Modified: 2016-12-05 21:27 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16164: Making check expiration actions buttons (2.26 KB, patch)
2016-03-30 00:04 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 16164: Making check expiration actions buttons (2.39 KB, patch)
2016-04-02 08:14 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16164: Making check expiration actions buttons (2.51 KB, patch)
2016-04-03 21:33 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[PASSED QA] Bug 16164: Making check expiration actions buttons (2.58 KB, patch)
2016-04-04 20:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-03-30 00:01:59 UTC

    
Comment 1 Aleisha Amohia 2016-03-30 00:04:22 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-02 08:14:21 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-03 12:46:02 UTC
Hi Aleisha,
I noticed that the icon used for "renew" is different on the check expiration and on the subscription detail page - can you please check (maybe other spots too)?
Comment 4 Aleisha Amohia 2016-04-03 21:33:20 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2016-04-04 20:55:08 UTC
Created attachment 49878 [details] [review]
[PASSED QA] Bug 16164: Making check expiration actions buttons

EDIT: Using same font awesome icon for 'Renew' as in other places

To test:
1) Go to Serials -> Check expiration
2) Put in a date where one or more subscriptions will expire prior to this date
3) Confirm that column heading is now 'Actions'
4) Confirm that Edit and Renew now show as font awesome buttons
5) Confirm that the buttons don't wrap on narrower browsers
6) Confirm the buttons still work as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Brendan Gallagher 2016-04-07 00:06:06 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!