Bug 16172 - OAI Server tests broken by bug 15946
Summary: OAI Server tests broken by bug 15946
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Galen Charlton
URL:
Keywords:
Depends on: 15946
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-30 15:24 UTC by Tomás Cohen Arazi
Modified: 2016-12-05 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16172: fix OAI Server tests broken by bug 15946 (1.47 KB, patch)
2016-03-30 15:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 16172: fix OAI Server tests broken by bug 15946 (1.52 KB, patch)
2016-03-30 23:09 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 16172: fix OAI Server tests broken by bug 15946 (1.59 KB, patch)
2016-03-31 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2016-03-30 15:24:42 UTC
Bug 15946 fixed a couple problems regarding schema and metadata namespaces, but forgot to adjust the tests to reflect this behaviour change, thus, the tests are broken.

To reproduce:
- Run
  $ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail due to differences in the output.

Patch to come.
Comment 1 Tomás Cohen Arazi 2016-03-30 15:27:28 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-03-30 23:09:39 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-31 13:57:27 UTC
Created attachment 49735 [details] [review]
Bug 16172: fix OAI Server tests broken by bug 15946

This patch makes t/db_dependent/OAI/Server.t test for the correct
schema and metadata namespace.

To test:
- Run
  $ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail due to differences in the output.
- Apply the patch
- Run
  $ prove t/db_dependent/OAI/Server.t
=> SUCCESS: Tests now pass
- Sign off

Regards

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2016-03-31 13:59:47 UTC
Just quick big note: our Koha::OAI::Server::Repository is broken if HTTP::OAI 4.03 is installed (testing):
Can't locate object method "xslt" via package "Koha::OAI::Server::ListMetadataFormats" at Koha/OAI/
Server/Repository.pm line 139.

Everything is ok using Jessie
Comment 5 Brendan Gallagher 2016-03-31 16:52:33 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 6 Julian Maurice 2016-04-07 08:02:48 UTC
Not needed in stable versions, status changed to RESOLVED