Bug 16188 - SMS via email not applicable in India due to telecom regulation
Summary: SMS via email not applicable in India due to telecom regulation
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Indranil Das Gupta
QA Contact: Testopia
URL: https://lists.katipo.co.nz/pipermail/...
Keywords:
Depends on: 9021
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-01 16:03 UTC by Indranil Das Gupta
Modified: 2018-03-18 07:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Who signed the patch off:
Text to go in the release notes:
Informs users in India that the SMS via email to telco feature is not supported within India.
Version(s) released in:


Attachments
Bug 16188 - SMS via email not applicable in India due to telecom regulation (3.01 KB, patch)
2018-01-21 13:10 UTC, Indranil Das Gupta
Details | Diff | Splinter Review
Bug 16188 - SMS via email not applicable in India due to telecom regulation (3.21 KB, patch)
2018-01-22 06:19 UTC, Indranil Das Gupta
Details | Diff | Splinter Review
Bug - SMS via email not applicable in India due to telecom regulation (3.07 KB, patch)
2018-01-22 22:40 UTC, Indranil Das Gupta
Details | Diff | Splinter Review
Bug 16188: Followup - Add message where there are providers. (1.70 KB, patch)
2018-01-30 04:30 UTC, M. Tompsett
Details | Diff | Splinter Review
Bug - SMS via email not applicable in India due to telecom regulation (3.12 KB, patch)
2018-03-16 08:53 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 16188: Followup - Add message where there are providers. (1.77 KB, patch)
2018-03-16 08:54 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Indranil Das Gupta 2016-04-01 16:03:17 UTC
Due to the nature of telecom regulatory framework in India, bug 9021 will not work for 99% of 500+ million cell phones in India. Details as explained in this mail with specific examples - https://lists.katipo.co.nz/pipermail/koha/2016-April/045114.html

This patch adds a "note" for such exceptions like India in the provider setup screen.
Comment 1 Indranil Das Gupta 2018-01-21 13:10:55 UTC
Created attachment 70785 [details] [review]
Bug 16188 - SMS via email not applicable in India due to telecom regulation

This patch is applicable only for Indian users of Koha

Scenario : Under Indian law, transactional bulk SMS sending requires
pre-registration and approval of message templates with the Telecom Regulatory
Authority of India (TRAI). Most Indian telcos do not offer this facility and
even if offered, use of the feature introduced by Bug #9021 may expose the user
to serious civil and criminal liability due to unsanctioned use. More details
over here - https://lists.katipo.co.nz/pipermail/koha/2016-April/045124.html.

This patch informs users setting up their SMSSendDriver to "Email" that this
feature won't work in India. And even if they do this, it reiterates this
again at Home › Administration › SMS cellular providers.

Test plan
=========

1/ Apply the patch
2/ Check if warning is displayed when setting up the SMSSendDriver syspref as
   as well when accessing 'SMS cellular providers' under 'Administration ->
   Additional parameters'
Comment 2 M. Tompsett 2018-01-22 04:15:17 UTC
Comment on attachment 70785 [details] [review]
Bug 16188 - SMS via email not applicable in India due to telecom regulation

Review of attachment 70785 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
@@ +129,4 @@
>       -
>           - "Use the SMS::Send::"
>           - pref: SMSSendDriver
> +         - driver to send SMS messages. <em>(<a href="//lists.katipo.co.nz/pipermail/koha/2016-April/045114.html">Do not set this</a> to 'Email' if you are in India)</em><br/>

https: is missing.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/sms_providers.tt
@@ +55,5 @@
>                  [% ELSE %]
>  
>                      <div class="dialog message">
> +                        There are no SMS cellular providers defined.<br/><br/>
> +                        <em>This feature <a href="//lists.katipo.co.nz/pipermail/koha/2016-April/045114.html">does not work</a> if you are in India</em>

https: is missing.
Comment 3 Indranil Das Gupta 2018-01-22 06:19:47 UTC
Created attachment 70788 [details] [review]
Bug 16188 - SMS via email not applicable in India due to telecom regulation

This patch is applicable only for Indian users of Koha

Scenario : Under Indian law, transactional bulk SMS sending requires
pre-registration and approval of message templates with the Telecom Regulatory
Authority of India (TRAI). Most Indian telcos do not offer this facility and
even if offered, use of the feature introduced by Bug #9021 may expose the user
to serious civil and criminal liability due to unsanctioned use. More details
over here - https://lists.katipo.co.nz/pipermail/koha/2016-April/045124.html.

This patch informs users setting up their SMSSendDriver to "Email" that this
feature won't work in India. And even if they do this, it reiterates this
again at Home › Administration › SMS cellular providers.

Test plan
=========

1/ Apply the patch
2/ Check if warning is displayed when setting up the SMSSendDriver syspref as
   as well when accessing 'SMS cellular providers' under 'Administration ->
   Additional parameters'
Comment 4 Indranil Das Gupta 2018-01-22 22:40:44 UTC
Created attachment 70813 [details] [review]
Bug - SMS via email not applicable in India due to telecom regulation

This patch is applicable only for Indian users of Koha

Scenario : Under Indian law, transactional bulk SMS sending requires
pre-registration and approval of message templates with the Telecom Regulatory
Authority of India (TRAI). Most Indian telcos do not offer this facility and
even if offered, use of the feature introduced by Bug #9021 may expose the user
to serious civil and criminal liability due to unsanctioned use. More details
over here - https://lists.katipo.co.nz/pipermail/koha/2016-April/045124.html.

This patch informs users setting up their SMSSendDriver to "Email" that this
feature won't work in India. And even if they do this, it reiterates this
again at Home › Administration › SMS cellular providers.

Test plan
=========

1/ Apply the patch

2/ Check if warning is displayed when setting up the SMSSendDriver syspref as
   as well when accessing 'SMS cellular providers' under 'Administration ->
   Additional parameters'
Comment 5 M. Tompsett 2018-01-23 05:51:01 UTC
Comment on attachment 70813 [details] [review]
Bug - SMS via email not applicable in India due to telecom regulation

Review of attachment 70813 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/sms_providers.tt
@@ +55,5 @@
>                  [% ELSE %]
>  
>                      <div class="dialog message">
> +                        There are no SMS cellular providers defined.<br/><br/>
> +                        <em>This feature <a href="https://lists.katipo.co.nz/pipermail/koha/2016-April/045114.html">does not work</a> if you are in India.</em>

This only displays when the cellular providers list is empty. This should likely be displayed by itself all the time.
Comment 6 M. Tompsett 2018-01-30 04:30:42 UTC
Created attachment 71054 [details] [review]
Bug 16188: Followup - Add message where there are providers.

Before patch, the warning is only displayed if the provider
list is empty.

After the patch, a more pronounced warning is displayed when
there is at least one provider.

TEST PLAN
---------
1) Apply first patch.
2) restart_all
3) Warning is visible in Patron preferences for setting
   SMS::Driver::Email.
4) Set it to Email anyways.
5) SMS Providers becomes visible in Administration
6) Warning is visible when there are no providers.
7) Create a provider.
   -- warning disappears.
8) apply this second patch
9) restart_all
10) Reload the SMS Providers page
11) There is now a very visible warning.
12) Run koha qa test tools.
Comment 7 Brendan Gallagher 2018-03-16 08:53:59 UTC
Created attachment 72995 [details] [review]
Bug - SMS via email not applicable in India due to telecom regulation

This patch is applicable only for Indian users of Koha

Scenario : Under Indian law, transactional bulk SMS sending requires
pre-registration and approval of message templates with the Telecom Regulatory
Authority of India (TRAI). Most Indian telcos do not offer this facility and
even if offered, use of the feature introduced by Bug #9021 may expose the user
to serious civil and criminal liability due to unsanctioned use. More details
over here - https://lists.katipo.co.nz/pipermail/koha/2016-April/045124.html.

This patch informs users setting up their SMSSendDriver to "Email" that this
feature won't work in India. And even if they do this, it reiterates this
again at Home › Administration › SMS cellular providers.

Test plan
=========

1/ Apply the patch

2/ Check if warning is displayed when setting up the SMSSendDriver syspref as
   as well when accessing 'SMS cellular providers' under 'Administration ->
   Additional parameters'

https://bugs.koha-community.org/show_bug.cgi?id=16188

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 8 Brendan Gallagher 2018-03-16 08:54:17 UTC
Created attachment 72996 [details] [review]
Bug 16188: Followup - Add message where there are providers.

Before patch, the warning is only displayed if the provider
list is empty.

After the patch, a more pronounced warning is displayed when
there is at least one provider.

TEST PLAN
---------
1) Apply first patch.
2) restart_all
3) Warning is visible in Patron preferences for setting
   SMS::Driver::Email.
4) Set it to Email anyways.
5) SMS Providers becomes visible in Administration
6) Warning is visible when there are no providers.
7) Create a provider.
   -- warning disappears.
8) apply this second patch
9) restart_all
10) Reload the SMS Providers page
11) There is now a very visible warning.
12) Run koha qa test tools.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 9 Katrin Fischer 2018-03-18 07:40:58 UTC
Hi Indranil, I was wondering, maybe it would be nicer to create a new wiki page for this information, so we can keep it updated more easily, what do you think?

If you change it, please also fix the commit message on the first patch! Thx!

FQA = waiting for an answer to the question