Go to administration - library EAN Add a new library EAN Enter only subscription and save Try to edit again Notice subscription is empty and saving will create another entry
It looks like the edit link expects an EAN as a parameter. I think it would be better to make this a required field and also use the existing ee_id to drive the actions.
Note: delete has broken links to - you can't delete entries there. Upping severity.
Created attachment 50357 [details] [review] Bug 16256 - Can't edit library EAN if you leave EAN empty Test Plan: 1) Create an empty EAN 2) Edit it and save 3) Note you get a new EAN row 4) Apply this patch 5) Edit the empty EAN again 6) Note you now get an updated EAN and not a new row
Created attachment 50368 [details] [review] Bug 16256 - Can't edit library EAN if you leave EAN empty Test Plan: 1) Create an empty EAN 2) Edit it and save 3) Note you get a new EAN row 4) Apply this patch 5) Edit the empty EAN again 6) Note you now get an updated EAN and not a new row Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> Depends on bug 16208 (which depends on 16206)
Hm, I hae applied 16206, 16208 and then this patch. I have problems with 16208, although the id is now used in the links and the same here - the problem remains even tho the edit screen is called with the id in the URL. The description is empty, even when one was set on creating the library ean and it will save as a new line.
Created attachment 50395 [details] [review] Bug 16256 - Can't edit library EAN if you leave EAN empty Test Plan: 1) Create an empty EAN 2) Edit it and save 3) Note you get a new EAN row 4) Apply this patch 5) Edit the empty EAN again 6) Note you now get an updated EAN and not a new row Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> Depends on bug 16208 (which depends on 16206)
Created attachment 50448 [details] [review] [PASSED QA] Bug 16256 - Can't edit library EAN if you leave EAN empty Test Plan: 1) Create an empty EAN 2) Edit it and save 3) Note you get a new EAN row 4) Apply this patch 5) Edit the empty EAN again 6) Note you now get an updated EAN and not a new row Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> Depends on bug 16208 (which depends on 16206) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Not needed in stable versions, status changed to RESOLVED