Bug 16258 - Add a preference to turn EDIFACT off
Summary: Add a preference to turn EDIFACT off
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Colin Campbell
QA Contact: Testopia
URL:
Keywords:
Depends on: 7736
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-14 06:05 UTC by Katrin Fischer
Modified: 2017-03-17 09:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (7.45 KB, patch)
2016-05-04 12:44 UTC, Colin Campbell
Details | Diff | Splinter Review
Proposed patch (7.72 KB, patch)
2016-05-05 05:53 UTC, Colin Campbell
Details | Diff | Splinter Review
Bug 16258 Add a syspref to govern EDIFACT functionality (7.71 KB, patch)
2016-08-17 14:47 UTC, M. Tompsett
Details | Diff | Splinter Review
Button Create EDIFACT order still appears (39.23 KB, image/png)
2016-08-18 13:00 UTC, Marc Véron
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2016-04-14 06:05:58 UTC
Acq is a complicated module and the new EDIFACT related options and features add another layer of complexity. It would be good if the feature could be turned off for libraries not interested in the functionality to help simplify working with acq a bit again.
Comment 1 Marc Véron 2016-04-15 13:23:21 UTC
+1
Comment 2 Colin Campbell 2016-04-18 11:08:50 UTC
Yes a 'use edifact' syspreference which if set to N (default) hides the edifact screens and links - which in fact are few
Comment 3 Katrin Fischer 2016-04-18 14:14:33 UTC
Hi Colin, EDIFACT appeared to be turnted on for me automatically. Are you sure this has been added? There is no mention of EDIFACT in the sysprefs.sql file:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/sysprefs.sql;h=ef4c3f0aef428b2cf2dd592a7273389333a818ed;hb=2a8c68936dd7fd5c82af339db968eb67cb93a082
Comment 4 Katrin Fischer 2016-04-18 14:15:11 UTC
I was also thinking about additional columns and buttons in other places - I haven't been able to get a total overview of the EDIFACT feature so far - but i seems there is something new on basket summary as well.
Comment 5 Katrin Fischer 2016-04-18 15:28:36 UTC
Hm, I found  134 ('EDIInvoicesShippingBudget',NULL,NULL,'The budget code used to allocate shipping charges to when processing EDI Invoice messages','free'), now - recheckign for EDI, but nothing else.
Comment 6 Colin Campbell 2016-05-04 11:14:26 UTC
In most places if there are no edifact vendors present the functionality gets disabled. The main feature to control is probably the admin screens. A syspref shouldnt be to turn it off but to enable it - I'll see if I can generate a patch to add an enabling system preference
Comment 7 Colin Campbell 2016-05-04 12:44:23 UTC Comment hidden (obsolete)
Comment 8 Colin Campbell 2016-05-05 05:53:09 UTC Comment hidden (obsolete)
Comment 9 M. Tompsett 2016-08-17 14:47:17 UTC
Created attachment 54539 [details] [review]
Bug 16258 Add a syspref to govern EDIFACT functionality

Adds an "Edifact" systempreference to govern whether edifact processing
is enabled. In most places this is hidden if the current
vendor does not appear in the edi vendors table. This preference
hides the admin screens which define this and a couple of links.

Also fixes an anomaly whereby the basketgroup screen was not
making the same check on whether edi ordering should be enabled as
the basket screen. Both now use the same logic.

Rebase by mtompset@hotmail.com
Comment 10 Marc Véron 2016-08-18 13:00:55 UTC
Created attachment 54567 [details]
Button Create EDIFACT order still appears

If syspref "Edifact" is disabled but the vendor has an Edifact account, the button "Create EDIFACT order" still displays.
I would expect that it does no longer appear.
Comment 11 Aleisha Amohia 2016-08-23 00:12:12 UTC
This patch works well, however there are some things that should be considered and improved before signing off on this:
1) With Edifact disabled, the EDI links still appear in the Admin sidebar navigation
2) With Edifact disabled, I can still directly navigate to edi_accounts.pl etc., either through the sidebar nav or going straight to the URL.
Comment 12 Marc Véron 2017-03-17 09:27:30 UTC
Patch no longer applies.