Bug 16340 - JS variable in opac-bottom.inc is declared two times
Summary: JS variable in opac-bottom.inc is declared two times
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16243
  Show dependency treegraph
 
Reported: 2016-04-25 15:55 UTC by Héctor Eduardo Castro Avalos
Modified: 2016-12-05 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16340: JS variable in opac-bottom.inc is declared two times (1.25 KB, patch)
2016-04-25 16:00 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16340: JS variable in opac-bottom.inc is declared two times (1.30 KB, patch)
2016-04-25 23:54 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 16340: JS variable in opac-bottom.inc is declared two times (1.37 KB, patch)
2016-04-26 15:46 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Héctor Eduardo Castro Avalos 2016-04-25 15:55:18 UTC
Dlecared JS variable in opac-bottom.inc delcared two times

var found when working with ENH 16243
Comment 1 Héctor Eduardo Castro Avalos 2016-04-25 16:00:56 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-04-25 23:54:55 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-04-26 15:46:50 UTC
Created attachment 50724 [details] [review]
Bug 16340: JS variable in opac-bottom.inc is declared two times

MSG_NO_RECORD_SELECTED declared two times

To test: Go to cart and list (virtual shelves) in OPAC and
verify if those pages work as expected

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2016-04-29 16:38:15 UTC
Pushed to master for Koha 16.05, thanks Hector!
Comment 5 Julian Maurice 2016-05-16 12:09:59 UTC
Patch pushed to 3.22.x, will be in 3.22.7