Bug 16341 - Revise the way table controls look on the title detail page
Summary: Revise the way table controls look on the title detail page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/catalogue/detail.pl?bib...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-25 16:34 UTC by Owen Leonard
Modified: 2016-12-05 21:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot showing the item selection controls before an after proposed patch (57.99 KB, image/png)
2016-04-25 16:34 UTC, Owen Leonard
Details
Bug 16341 - Revise the way table controls look on the title detail page (9.76 KB, patch)
2016-04-25 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 16341: Revise the way table controls look on the title detail page (9.81 KB, patch)
2016-04-26 14:50 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[PASSED QA] Bug 16341: Revise the way table controls look on the title detail page (9.86 KB, patch)
2016-04-26 21:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-25 16:34:46 UTC
Created attachment 50657 [details]
Screenshot showing the item selection controls before an after proposed patch

I propose a change to bibliographic detail page, revising the appearance of various controls tied to the holdings table: Activate filters, select all, etc. See the attached screenshot for a before and after.
Comment 1 Owen Leonard 2016-04-25 16:55:49 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-04-26 14:50:35 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-26 21:52:23 UTC
Created attachment 50764 [details] [review]
[PASSED QA] Bug 16341: Revise the way table controls look on the title detail page

This patch makes changes to the way links are displayed on the
bibliographic detail page, adding Font Awesome icons to make the links
clearer. Some instances of the "onclick" attribute are removed.

This patch also converts the "Edit" link to a Bootstrap button.

To test, apply the patch and locate a title in the catalog with multiple
holdings from different branches.

Test all the table controls under a variety of conditions:

- Logged in as a user who can or can't edit items
- Logged in as a user who can or can't perform batch item operations.
- With the StaffDetailItemSelection system preference enabled or
  disabled.
- With the SeparateHoldings system preference turned on or off.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall 2016-04-29 16:19:35 UTC
Pushed to master for the Koha 16.05 release. Thanks Owen. This looks great!