Bug 16342 - Plack breaks Baker and Taylor cover images
Summary: Plack breaks Baker and Taylor cover images
Status: RESOLVED DUPLICATE of bug 16636
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-25 19:38 UTC by Nick Clemens (kidclamp)
Modified: 2019-06-07 10:29 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 16342: Fix variable scope to make BakerTaylor works under plack (2.58 KB, patch)
2018-05-08 20:19 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2016-04-25 19:38:10 UTC
BakerTaylorImageURL is constructed through C4/External/BakerTaylor.pm

under plack the initialisation/passing of these variables doesn't work

To recreate (you do not need a B&T account):
Put any old values into:
BakerTaylorBookstoreURL
BakerTaylorUsername
BakerTaylorPassword 
and set  BakerTaylorEnabled to 'Add'

With plack off: Images should be constructed with URL like:
http://contentcafe2.btol.com/ContentCafe/Jacket.aspx?UserID=$user&Password=$pass&Options=Y&Return=T&Type=S&Value

With plack enabled you get img src=BakerTaylorLinkURL...
Comment 1 Jonathan Druart 2016-05-02 15:14:59 UTC
Nick, this comes certainly from the scope of $user and $pass.
Try making it a clean OO module, or use subroutines to retrieve the user and password infos.
Comment 2 Maureen Wynkoop 2018-05-08 19:54:51 UTC
This looks like a really lonely, ignored bug.  I'm very sad that I can't have book jackets on my lists because I added value to my catalog by using Baker and Taylor for enhanced content!
Comment 3 Jonathan Druart 2018-05-08 20:19:17 UTC
Created attachment 75190 [details] [review]
Bug 16342: Fix variable scope to make BakerTaylor works under plack
Comment 4 Jonathan Druart 2018-05-08 20:19:57 UTC
Hi Maureen, can you try this patch?

I have not tried it.
Comment 5 Nick Clemens (kidclamp) 2018-05-09 11:45:55 UTC
I think bug 16636 fixed this, I cannot recreate.
Comment 6 Nick Clemens (kidclamp) 2019-06-07 10:29:55 UTC

*** This bug has been marked as a duplicate of bug 16636 ***