Bug 16369 - Clean up and improve plugins template
Summary: Clean up and improve plugins template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/plugins/plugins-home.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-27 15:21 UTC by Owen Leonard
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16369 - Clean up and improve plugins template (13.02 KB, patch)
2016-04-27 15:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16369 - Clean up and improve plugins template (13.14 KB, patch)
2016-04-28 12:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16369 - Clean up and improve plugins template (13.17 KB, patch)
2016-05-02 12:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-04-27 15:21:42 UTC
The template for managing plugins should be revised to better comply with established interface patterns.
Comment 1 Owen Leonard 2016-04-27 15:50:15 UTC Comment hidden (obsolete)
Comment 2 Arslan Farooq 2016-04-28 04:14:45 UTC
Hi Owen,

when applying the patch, it says:

--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 16369 - Clean up and improve plugins template
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
Failed to merge in the changes.
Patch failed at 0001 Bug 16369 - Clean up and improve plugins template
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Comment 3 Owen Leonard 2016-04-28 12:45:18 UTC Comment hidden (obsolete)
Comment 4 Arslan Farooq 2016-04-29 06:16:37 UTC
This patch makes multiple changes to the plugins home page template to
bring it up to date with current interface patterns.

Test the following changes:

- Breacrumb links have been corrected to include "Tools" in the path.
  Verify that this link is correct.
- A toolbar has been added for an "Upload plugin" button. Uploading is
  an action, not a view, so it should be displayed in a toolbar. Verify
  that the button works correctly.
- Messages are now formatted as messages rather than as headings. To
  test, trigger a message by, for instance, uninstalling all plugins or
  passing an invalid "method" parameter with the URL.
- Incorrect capitalization corrected.
- Plugin actions are moved to a single "Actions" dropdown menu. This
  includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test
  that all these menu options work correctly.
- The standard "Tools" sidebar menu has been added.
- An "onclick" attribute has been removed in favor of defining the event
  in JavaScript. Test by choosing the 'Uninstall' menu item for a
  plugin. Test both confirm and cancel actions.

Also changed:

- Corrected capitalization on the tools home page.
- Adding missing plugins link to the tools sidebar menu.

------------------------------------

I tested everything one by one, and things works OK.

Did qa tools check, and I get this: http://paste.koha-community.org/431 I'm thinking may be something wrong with my set-up?

------------------------------------

While testing this patch, discovered something and created new bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16391
Comment 5 Bernardo Gonzalez Kriegel 2016-04-30 16:37:29 UTC
(In reply to Arslan Farooq from comment #4)
> 
> Did qa tools check, and I get this: http://paste.koha-community.org/431 I'm
> thinking may be something wrong with my set-up?
> 

Perhaps a byproduct of kohadevbox.
No errors for me, you can sign.


 OK     koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
   OK     forbidden patterns
   OK     spelling
   OK     tt_valid
   OK     valid_template

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
   OK     forbidden patterns
   OK     spelling
   OK     tt_valid
   OK     valid_template

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
   OK     forbidden patterns
   OK     spelling
   OK     tt_valid
   OK     valid_template
Comment 6 Arslan Farooq 2016-04-30 18:26:18 UTC
his patch makes multiple changes to the plugins home page template to
bring it up to date with current interface patterns.

Test the following changes:

- Breacrumb links have been corrected to include "Tools" in the path.
  Verify that this link is correct.
- A toolbar has been added for an "Upload plugin" button. Uploading is
  an action, not a view, so it should be displayed in a toolbar. Verify
  that the button works correctly.
- Messages are now formatted as messages rather than as headings. To
  test, trigger a message by, for instance, uninstalling all plugins or
  passing an invalid "method" parameter with the URL.
- Incorrect capitalization corrected.
- Plugin actions are moved to a single "Actions" dropdown menu. This
  includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test
  that all these menu options work correctly.
- The standard "Tools" sidebar menu has been added.
- An "onclick" attribute has been removed in favor of defining the event
  in JavaScript. Test by choosing the 'Uninstall' menu item for a
  plugin. Test both confirm and cancel actions.

Also changed:

- Corrected capitalization on the tools home page.
- Adding missing plugins link to the tools sidebar menu.

------------------------------------

I tested everything one by one, and things works OK.
Comment 7 Arslan Farooq 2016-04-30 18:27:07 UTC
Thank you Bernardo! :)
Comment 8 Jonathan Druart 2016-05-02 12:08:18 UTC
Created attachment 51093 [details] [review]
Bug 16369 - Clean up and improve plugins template

This patch makes multiple changes to the plugins home page template to
bring it up to date with current interface patterns.

Test the following changes:

- Breacrumb links have been corrected to include "Tools" in the path.
  Verify that this link is correct.
- A toolbar has been added for an "Upload plugin" button. Uploading is
  an action, not a view, so it should be displayed in a toolbar. Verify
  that the button works correctly.
- Messages are now formatted as messages rather than as headings. To
  test, trigger a message by, for instance, uninstalling all plugins or
  passing an invalid "method" parameter with the URL.
- Incorrect capitalization corrected.
- Plugin actions are moved to a single "Actions" dropdown menu. This
  includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test
  that all these menu options work correctly.
- The standard "Tools" sidebar menu has been added.
- An "onclick" attribute has been removed in favor of defining the event
  in JavaScript. Test by choosing the 'Uninstall' menu item for a
  plugin. Test both confirm and cancel actions.

Also changed:

- Corrected capitalization on the tools home page.
- Adding missing plugins link to the tools sidebar menu.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2016-05-02 12:09:23 UTC
I'd consider this patch as a bugfix.
Comment 10 Kyle M Hall 2016-05-03 15:18:52 UTC
Pushed to master for Koha 16.05, thanks Owen!
Comment 11 Julian Maurice 2016-05-16 08:33:29 UTC
Patch pushed to 3.22.x, will be in 3.22.7