To reproduce: - Go to cgi-bin/koha/circ/returns.pl (Home > Circulation > Check in) - Enter 2, hit Submit => Result: Check in message: No item with barcode 2 Nothing in intranet-error.log - Enter 1, hit Submit => Result: An error has occurred! Error 500 Intranet-error.log: returns.pl: No property outstanding! at /usr/share/kohaclone/Koha/Object.pm line 188 ...and about 10 more lines
Ok, it's not related to the barcode 1. I had an item with barcode 1. Changed the barcode to 111. It is checked out to patron A. Returnig leads to the error as in comment above. Trying to check out to a patron B leads to: Software error Can't call method "store" without a package or object reference at /usr/share/kohaclone/C4/Overdues.pm line 584.
Found: Overdues.pm line 588 tries to do an $accountline->set with column outstanding instead of amountoutstanding. Patch follows.
Created attachment 50888 [details] [review] Bug 16378: Overdues.pm: Can't call method "store" without a package or object reference Overdues.pm line 588 tries to do an $accountline->set with column outstanding instead of amountoutstanding. This patch fixes it. To test: - Verify that code change is correct. - Try to trigger a situation where an existing fine is updated (see comment in line 574 in C4/Overdues.pm)
Created attachment 50894 [details] [review] Bug 16378: Overdues.pm: Can't call method "store" without a package or object reference Overdues.pm line 588 tries to do an $accountline->set with column outstanding instead of amountoutstanding. This patch fixes it. To test: - Verify that code change is correct. - Try to trigger a situation where an existing fine is updated (see comment in line 574 in C4/Overdues.pm) Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
This bug can be triggered as well when trying to run misc/cronjobs/fines.pl (on some database with overdued items): No property outstanding! at /home/koha/devkohaclone/C4/Overdues.pm line 584 Can't call method "store" without a package or object reference at /home/koha/devkohaclone/C4/Overdues.pm line 584. Without the patch, fine calculations are pretty much completely broken, overdued items are unreturnable and so on. Upping severity to 'blocker'.
Created attachment 50905 [details] [review] Bug 16378: Overdues.pm: Can't call method "store" without a package or object reference Overdues.pm line 588 tries to do an $accountline->set with column outstanding instead of amountoutstanding. This patch fixes it. To test: - Verify that code change is correct. - Try to trigger a situation where an existing fine is updated (see comment in line 574 in C4/Overdues.pm) Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Not needed in stable versions, status changed to RESOLVED