If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! To reproduce: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ).
Created attachment 51127 [details] [review] Bug 16429 - Going to circulation from notice triggers may change logged in branch If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! Test Plan: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). 6) Apply this patch 7) Repeat steps 2-4 8) Note the branch no longer changes
Created attachment 51128 [details] [review] Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions.
Created attachment 51129 [details] [review] Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions.
Created attachment 51130 [details] [review] Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions.
Created attachment 51134 [details] [review] Bug 16429 - Going to circulation from notice triggers may change logged in branch If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! Test Plan: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). 6) Apply this patch 7) Repeat steps 2-4 8) Note the branch no longer changes Tested with both patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 51135 [details] [review] Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 51141 [details] [review] Bug 16429 - Going to circulation from notice triggers may change logged in branch If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! Test Plan: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). 6) Apply this patch 7) Repeat steps 2-4 8) Note the branch no longer changes Tested with both patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Heather Braum <hbraum@nekls.org>
Created attachment 51142 [details] [review] Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Heather Braum <hbraum@nekls.org>
Created attachment 51194 [details] [review] Bug 16429 - Going to circulation from notice triggers may change logged in branch If you edit notice triggers and then use the "Checko out" tab from the top bar, you may change your logged in library by accident! Test Plan: 1) Disable the system preference CircAutocompl 2) Go to the notice triggers 3) Select the triggers for a library other than the one you logged in as 4) Use the "Check out" tab at the top to check out to a patron 5) Note your logged in branch has changed ( you'll need to refresh the page if the check out search took you directly to one patron ). 6) Apply this patch 7) Repeat steps 2-4 8) Note the branch no longer changes Tested with both patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Good catch Kyle!
Created attachment 51195 [details] [review] Bug 16429 - Fix root problem The root of this issue is old code in circulation.pl that is no longer needed and leaves the affected scripts open to future regressions. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.05!
Patch pushed to 3.22.x, will be in 3.22.7