It appears that somehow the adding of issue_id to accountlines for new fines was missed! This is incredibly important, otherwise UpdasteFine will always create a new fine!
Created attachment 51394 [details] [review] Bug 16496 - accountlines.issue_id not set when new overdue is processed It appears that somehow the adding of issue_id to accountlines for new fines was missed! This is incredibly important, otherwise UpdasteFine will always create a new fine! Test Plan: 1) Create a new overdue checkout 2) Run fines.pl to generate an accountline for it 3) Note it has no issue_id 4) Apply this patch 5) Repeat steps 1 and 2 6) Note it now has an issue_id!
Created attachment 51395 [details] [review] Bug 16496 - accountlines.issue_id not set when new overdue is processed It appears that somehow the adding of issue_id to accountlines for new fines was missed! This is incredibly important, otherwise UpdateFine will always create a new fine! Test Plan: 1) Create a new overdue checkout 2) Run fines.pl to generate an accountline for it 3) Note it has no issue_id 4) Apply this patch 5) Repeat steps 1 and 2 6) Note it now has an issue_id!
s/UpdasteFine/UpdateFine
Ahh looks like this was missed when bug 13790 was done, will test now
Created attachment 51397 [details] [review] Bug 16496 - accountlines.issue_id not set when new overdue is processed It appears that somehow the adding of issue_id to accountlines for new fines was missed! This is incredibly important, otherwise UpdateFine will always create a new fine! Test Plan: 1) Create a new overdue checkout 2) Run fines.pl to generate an accountline for it 3) Note it has no issue_id 4) Apply this patch 5) Repeat steps 1 and 2 6) Note it now has an issue_id! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 51399 [details] [review] Bug 16496 - accountlines.issue_id not set when new overdue is processed It appears that somehow the adding of issue_id to accountlines for new fines was missed! This is incredibly important, otherwise UpdateFine will always create a new fine! Test Plan: 1) Create a new overdue checkout 2) Run fines.pl to generate an accountline for it 3) Note it has no issue_id 4) Apply this patch 5) Repeat steps 1 and 2 6) Note it now has an issue_id! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 51400 [details] [review] Bug 16496: Add test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for the 16.05 release! Thanks for the unit test Jonathan!
Not needed in stable versions, status changed to RESOLVED