Bug 16510 - When record items exceed OpacMaxItemsToDisplay opacSerialDefaultTab is ignored
Summary: When record items exceed OpacMaxItemsToDisplay opacSerialDefaultTab is ignored
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 14209 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-05-13 00:24 UTC by Nick Clemens
Modified: 2017-09-11 18:08 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2016-05-13 00:24:12 UTC
In opac-detail.pl the if construct checks (@itemloop) to see if holdings should be displayed, however, if items exceed OpacMaxItemsToDisplay @itemloop isn't populated and the syspref is ignored

my $opac_serial_default = C4::Context->preference('opacSerialDefaultTab');
my $defaulttab =
    $opac_serial_default eq 'subscriptions' && $subscriptionsnumber
        ? 'subscriptions' :
    $opac_serial_default eq 'serialcollection' && @serialcollections > 0
        ? 'serialcollection' :
    $opac_serial_default eq 'holdings' && scalar (@itemloop) > 0
        ? 'holdings' :
    $subscriptionsnumber
        ? 'subscriptions' :
    @serialcollections > 0
        ? 'serialcollection' : 'subscriptions';
$template->param('defaulttab' => $defaulttab);
Comment 1 Nick Clemens 2016-05-13 17:03:30 UTC
*** Bug 14209 has been marked as a duplicate of this bug. ***