I have a few minor improvements and fixes for the Quotes editor and upload process: - Removing 'onclick' - Making the 'Cancel upload' button work correctly - Add a 'Cancel upload' button to the toolbar - Capitalization corrections
Created attachment 51472 [details] [review] Bug 16513 - Improvements and fixes for quote upload process This patch fixes some minor bugs and adds a small enhancement to the quotes editor and quotes upload pages. To test, apply the patch and go to Tools -> Quote editor - In the table of quotes, clicking the "ID" table header should trigger an alert, "Click on the quote's ide to select..." - Go to "Import quotes" and select a file to upload. - On the upload preview page you should see a new "Cancel import" button. Clicking it should return you to the quotes upload page after asking for confirmation. - Test the upload cancel button: - If you have fast reflexes or are uploading a file large enough, you should be able to see a "Cancel upload" button during the upload process. - Clicking this button should cancel the upload and return you to the quote upload page.
Can not test upload (with and without patch), see Bug 16589
Created attachment 51904 [details] [review] Bug 16513 - Improvements and fixes for quote upload process This patch fixes some minor bugs and adds a small enhancement to the quotes editor and quotes upload pages. To test, apply the patch and go to Tools -> Quote editor - In the table of quotes, clicking the "ID" table header should trigger an alert, "Click on the quote's ide to select..." - Go to "Import quotes" and select a file to upload. - On the upload preview page you should see a new "Cancel import" button. Clicking it should return you to the quotes upload page after asking for confirmation. - Test the upload cancel button: - If you have fast reflexes or are uploading a file large enough, you should be able to see a "Cancel upload" button during the upload process. - Clicking this button should cancel the upload and return you to the quote upload page. Tested on top of Bug 16589, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 52542 [details] [review] Bug 16513 - Improvements and fixes for quote upload process This patch fixes some minor bugs and adds a small enhancement to the quotes editor and quotes upload pages. To test, apply the patch and go to Tools -> Quote editor - In the table of quotes, clicking the "ID" table header should trigger an alert, "Click on the quote's ide to select..." - Go to "Import quotes" and select a file to upload. - On the upload preview page you should see a new "Cancel import" button. Clicking it should return you to the quotes upload page after asking for confirmation. - Test the upload cancel button: - If you have fast reflexes or are uploading a file large enough, you should be able to see a "Cancel upload" button during the upload process. - Clicking this button should cancel the upload and return you to the quote upload page. Tested on top of Bug 16589, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Not sure 'id_help' is a good id, but not important :)
Pushed to master for Koha 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.02.