Bug 16572 - Warnings on load_sql makes web installer fail
Summary: Warnings on load_sql makes web installer fail
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: master
Hardware: All All
: P5 - low critical (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-24 00:12 UTC by Bernardo Gonzalez Kriegel
Modified: 2019-06-27 09:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16572: Warnings on load_sql makes web installer fail (1.60 KB, patch)
2016-05-24 01:28 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2016-05-24 00:12:09 UTC
Bug 13669 redirect warnings from load_sql use of DBIX::RunSQL to sdterr, and makes web installer fail.
Comment 1 Bernardo Gonzalez Kriegel 2016-05-24 01:28:44 UTC
Created attachment 51726 [details] [review]
Bug 16572: Warnings on load_sql makes web installer fail

Last patch on Bug 13669 redirects all strings to stderr,
warning included. That makes web installer fail.

To test:
Current master (Bug 13669 pushed)
1) Try web installer, it fails
2) Apply this patch, try again,
now succeeds*

* Unless Mysql 5.7, that needs another bug.

I'm not considering this a 'good' solution, just a quick fix.
A better approach is welcomed, just obsolete this patch
and upload a new one, I'll sign :)
Comment 2 Bernardo Gonzalez Kriegel 2016-05-24 18:57:21 UTC
Fortunately this is not needed any more.

DBIx::RunSQL author kindly accepted to update the module, now 0.14, and sql create statements does not rise warnings any more.

I tested a complete marc21 + sample data on Ubuntu 14.04/MySQL 5.5.49 without incident