Bug 16577 - Improve call number browser plugin
Summary: Improve call number browser plugin
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/cataloguing/plugin_laun...
Keywords:
Depends on: 13364
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-24 16:00 UTC by Owen Leonard
Modified: 2017-12-07 22:17 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16577 - Improve call number browser plugin (9.15 KB, patch)
2016-05-24 16:35 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16577 - Improve call number browser plugin (9.29 KB, patch)
2016-05-28 09:17 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 16577 - Improve call number browser plugin (9.36 KB, patch)
2016-06-12 11:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16577: Minor improvement on else if statements (1.10 KB, patch)
2016-06-12 11:29 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-05-24 16:00:22 UTC
Bug 13364 added a call number browser cataloging plugin which can be used to check for duplicate call numbers when adding an item. I have several markup fixes and style improvements for the template.
Comment 1 Owen Leonard 2016-05-24 16:35:20 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2016-05-28 09:17:39 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-06-12 11:29:00 UTC
Created attachment 52283 [details] [review]
Bug 16577 - Improve call number browser plugin

This patch makes several markup and style improvements to the call
number browser plugin added by Bug 13364. Some of the changes:

- The size of the pop-up window has been increased slightly for a less
  cramped display.
- Page structure has been updated to match similar pop-up windows.
- Page structure has been improved to further accommodate the option of
  viewing the call number browser as a full page rather than a pop-up
  window (although as far as I can tell it is not linked to in this mode
  anywhere).
- Row highlighting has been updated so that page styles are not being
  passed explicitly by the script. Highlight colors have been changed to
  make things more readable.
- DataTables-related markup has been removed because it was not being
  used. It doesn't make sense to re-order table rows when the purpose of
  the table is to display call number order.

To test, apply the patch and edit a framework so that the item call
number field uses the 'cn_browser.pl' plugin.

- Create or edit an item in cataloging.
- Enter an existing call number into the call number field.
  - Click the '...' link next to the call number.
    - In the call number browser pop-up, verify that items matching your
      call number are highlighted in red.
    - Verify that the new 'Close' button at the bottom of the page works
      correctly.
- Enter a call number which doesn't exist in the call number field
  - Click the '...' link to trigger the browser.
    - Verify that there is a row highlighted in green marking the sort
      order of the call number you chose.
- Navigate directly to
  /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl
  - The page should appear like a normal full page, with header search,
    breadcrumbs, etc. Performing a search for call numbers should work
    like it did in the pop-up context.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Works as described. Pleasing to the eye

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2016-06-12 11:29:05 UTC
Created attachment 52284 [details] [review]
Bug 16577: Minor improvement on else if statements

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2016-06-12 11:30:12 UTC
(In reply to Owen Leonard from comment #1)
> - DataTables-related markup has been removed because it was not being
>   used. It doesn't make sense to re-order table rows when the purpose of
>   the table is to display call number order.

But we could have kept the constructor anyway :)
Comment 6 Kyle M Hall 2016-06-17 16:09:31 UTC
Pushed to master for Koha 16.11, thanks Owen!