Bug 16606 - Checkout settings dropdown should have a preference to stay open all the time
Summary: Checkout settings dropdown should have a preference to stay open all the time
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-26 16:13 UTC by Christopher Brannon
Modified: 2020-01-11 13:19 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 16606 Checkout settings dropdown should have a preference to stay (4.33 KB, patch)
2017-01-18 22:10 UTC, Caitlin Goodger
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 16606 Checkout settings dropdown should have a preference to stay open all the time (4.39 KB, patch)
2017-01-24 15:26 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2016-05-26 16:13:30 UTC
Not everyone is concerned with the additional space taken up with the new Checkout settings.  It would be helpful if these options could be set to always show.

For now I will use a jQuery to force it open, but a preference would be preferable.  No pun intended.

Christopher
Comment 1 Caitlin Goodger 2017-01-18 22:10:34 UTC
Created attachment 59187 [details] [review]
Bug 16606 Checkout settings dropdown should have a preference to stay

open all the time
Test Plan
1: Update database
2: Turn on the CheckoutSettingsVisibility syspref
3: Go to your checkouts
4: COnfirm that the checkout settings is open
5: Turn the syspref and go back to your checkouts
6: Confirm that the Checkout settings are closed
Comment 2 Owen Leonard 2017-01-24 15:26:59 UTC
Created attachment 59506 [details] [review]
[SIGNED-OFF] Bug 16606 Checkout settings dropdown should have a preference to stay open all the time

Test Plan
1: Update database
2: Turn on the CheckoutSettingsVisibility syspref
3: Go to your checkouts
4: COnfirm that the checkout settings is open
5: Turn the syspref and go back to your checkouts
6: Confirm that the Checkout settings are closed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2017-01-26 10:49:43 UTC
I do not think this option should be controlled by a syspref.
It would better to let it open if the user open it, don't you think?
To do that we could use a cookie to store user's preference.
Comment 4 Christopher Brannon 2017-02-08 22:32:25 UTC
(In reply to Jonathan Druart from comment #3)
> I do not think this option should be controlled by a syspref.
> It would better to let it open if the user open it, don't you think?
> To do that we could use a cookie to store user's preference.

While I agree, current method on this page to show the checkouts table and keep it open is to check a box.  It would be preferred to pick one method and stick with it.  If I am understanding, you would like it to stay open if the user opens it, and stay closed if the user closes it.

I like that, but if we do that, I would say we should open another ticket to make the table work that way too.  Otherwise, people are looking for checkboxes and preferences based off current practices.  Don't you think?
Comment 5 Jonathan Druart 2017-02-09 06:59:18 UTC
(In reply to Christopher Brannon from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > I do not think this option should be controlled by a syspref.
> > It would better to let it open if the user open it, don't you think?
> > To do that we could use a cookie to store user's preference.
> 
> While I agree, current method on this page to show the checkouts table and
> keep it open is to check a box.  It would be preferred to pick one method
> and stick with it.  If I am understanding, you would like it to stay open if
> the user opens it, and stay closed if the user closes it.
> 
> I like that, but if we do that, I would say we should open another ticket to
> make the table work that way too.  Otherwise, people are looking for
> checkboxes and preferences based off current practices.  Don't you think?

IMO It makes sense to have a checkbox to save the show/hide table choice, not for the show/hide settings. Otherwise I have no idea how we could get the show/hide table user's choice. A toggle with the caret down icon would look bizarre.

Ccing Owen to get his opinion.
Comment 6 Marjorie Barry-Vila 2017-05-03 15:57:34 UTC
(In reply to Christopher Brannon from comment #0)
> Not everyone is concerned with the additional space taken up with the new
> Checkout settings.  It would be helpful if these options could be set to
> always show.
> 
> For now I will use a jQuery to force it open, but a preference would be
> preferable.  No pun intended.
> 
> Christopher

Hi,
Could you share your code JQuery? I did not find it on wiki.
Regards,
Marjorie