Bug 16638 - Business::ISBN versioning scheme says it needs upgrade, but doesn't
Summary: Business::ISBN versioning scheme says it needs upgrade, but doesn't
Status: RESOLVED DUPLICATE of bug 17880
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-02 02:42 UTC by Nicholas van Oudtshoorn
Modified: 2017-01-17 09:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas van Oudtshoorn 2016-06-02 02:42:57 UTC
Busy upgrading to 16.05 at the moment, and have noticed an issue with Business::ISBN. Here on Fedora (using my KohaExtra repository: dnf copr enable vanoudt/KOHAExtra ) Business::ISBN is at version 2.010. That's a 10 at the end, as opposed to a 5 which the required version (2.05) asks for. It's a weird numbering scheme, but the changelog shows that 2.010 is actually a later release than 2.05 . Naturally, koha_perl_deps.pl tells me that this module requires updating... but it doesn't. Not sure what the right fix here is...
Comment 1 Marc Véron 2016-06-02 05:41:25 UTC
This is related to Bug 5599 - koha_perl_deps.pl and PerlDependencies.pm don't compare $VERSION numbers correctly.
To get more information in such cases, I introduced Bug Bug 12790 - Perl modules: Display required version numbers on about page

Bug 5599 got a temporary fix for Graphics::Magick
-        'min_ver'  => '1.3.5'
+        'min_ver'  => '1.3.05'

This is a similar case (2.05 vs 2.010).

There are other issues waiting, e.g.
File::Path (2.07) 	2.08_01 
(compares correctly at the moment, but what about something like 2.08_01 vs 2.09 ?)

Maybe the following helps to get a sustainable solution:
http://stackoverflow.com/questions/19973852/perl-compare-version-numbers-5-1-5-10
Answer 6:
print version->declare('5.1')->numify;  # 5.00100
print version->declare('5.10')->numify; # 5.01000
Comment 2 Jonathan Druart 2017-01-17 09:23:40 UTC

*** This bug has been marked as a duplicate of bug 17880 ***