Bug 16648 - Add Content system preferences for all CSS and XSLT sysprefs that accept a URL.
Summary: Add Content system preferences for all CSS and XSLT sysprefs that accept a URL.
Status: RESOLVED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
: 11884 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-06-03 13:02 UTC by Barton Chittenden
Modified: 2023-09-10 11:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Barton Chittenden 2016-06-03 13:02:17 UTC
The following system preferences allow paths to be specified for CSS or XSLT files:

NoticeCSS
opaclayoutstylesheet
OpacAdditionalStylesheet
intranetcolorstylesheet
intranetstylesheet
SlipCSS

OPACXSLTDetailsDisplay
OPACXSLTResultsDisplay
XSLTDetailsDisplay
XSLTResultsDisplay

This causes administrative headaches, because the CSS or XSLT cannot be stored in the database -- for instance adding 'NoticeCSS' means that a css file must be created and hosted somewhere, and these assets risk being lost on server moves if hosted locally, or are an external point of failure if hosted remotely.

I suggest that for each CSS or XSLT path syspref, there should be a corresponding 'Content' variable:

-------------------------+---------------------------------+----------------------------------------------
Path Syspref             | Content Syspref                 | Content Path
-------------------------+---------------------------------+----------------------------------------------
CSS
-------------------------+---------------------------------+----------------------------------------------
NoticeCSS                | NoticeCSSContent                | cgi-bin/koha/css/NoticeCSS.css
opaclayoutstylesheet     | opaclayoutstylesheetContent     | cgi-bin/koha/css/opaclayoutstylesheet.css
OpacAdditionalStylesheet | OpacAdditionalStylesheetContent | cgi-bin/koha/css/OpacAdditionalStylesheet.css
intranetcolorstylesheet  | intranetcolorstylesheetContent  | cgi-bin/koha/css/intranetcolorstylesheet.css
intranetstylesheet       | intranetstylesheetContent       | cgi-bin/koha/css/intranetstylesheet.css
SlipCSS                  | SlipCSSContent                  | cgi-bin/koha/css/SlipCSS.css
-------------------------+---------------------------------+----------------------------------------------
XSLT
-------------------------+---------------------------------+----------------------------------------------
OPACXSLTDetailsDisplay   | OPACXSLTDetailsDisplayContent   | cgi-bin/koha/xslt/OPACXSLTDetailsDisplay.xslt
OPACXSLTResultsDisplay   | OPACXSLTResultsDisplayContent   | cgi-bin/koha/xslt/OPACXSLTResultsDisplay.xslt
XSLTDetailsDisplay       | XSLTDetailsDisplayContent       | cgi-bin/koha/xslt/XSLTDetailsDisplay.xslt
XSLTResultsDisplay       | XSLTResultsDisplayContent       | cgi-bin/koha/xslt/XSLTResultsDisplay.xslt
-------------------------+---------------------------------+----------------------------------------------
Comment 1 Barton Chittenden 2016-06-03 13:03:07 UTC
*** Bug 11884 has been marked as a duplicate of this bug. ***
Comment 2 Tomás Cohen Arazi 2016-06-14 15:24:08 UTC
Barton, as far as I can tell, XSLT's can be URLs and that is handled in XSLT_Handler.pm
Comment 3 Barton Chittenden 2016-06-14 18:23:09 UTC
(In reply to Tomás Cohen Arazi from comment #2)
> Barton, as far as I can tell, XSLT's can be URLs and that is handled in
> XSLT_Handler.pm

Tomás,

Yes -- I'm relying on the ability to use URLs for either CSS or XSLT.

My idea is that the 'content' system preference would provide a resource at a given URL, and then the standard system preferences for CSS or XSLT would use that URL... I think this might have been clearer if bugzilla hadn't decided to re-format my ascii art table ;-).