Bug 16767 - OPAC suggestions, existing suggestions don't show after placing a suggestion
Summary: OPAC suggestions, existing suggestions don't show after placing a suggestion
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-18 01:21 UTC by Nick Clemens (kidclamp)
Modified: 2019-10-14 19:58 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 16767 - OPAC suggestions, existing suggestions don't show after placing a suggestion (1.74 KB, patch)
2016-06-18 02:03 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2016-06-18 01:21:20 UTC
After placing a purchase suggestion on the opac the confirmation screen reads:

"Your suggestion has been submitted.

There are no pending purchase suggestions."

Place another, same result.

These lines in opac-suggestions.pl don't seem to be working as intended:

136 ^I^I$$suggestion{$_}='' foreach qw<title author publishercode copyrightdate place collectiontitle isbn STATUS>;
137 ^I^I$suggestions_loop =
138 ^I^I   &SearchSuggestion( $suggestion );
Comment 1 Nick Clemens (kidclamp) 2016-06-18 02:03:29 UTC
Created attachment 52503 [details] [review]
Bug 16767 - OPAC suggestions, existing suggestions don't show after placing a suggestion

To test:
1 - Before applying this patch, place some suggestions
2 - Note that on success you see no suggestions
3 - Apply this patch
4 - Add a suggestion, note you see the new suggestion and all other
5 - Add a duplicate suggestion, note suggestions is rejected and you see
all existing
Comment 2 Nick Clemens (kidclamp) 2016-06-18 02:04:15 UTC
Needs to be unit tested
Comment 3 Marc Véron 2016-06-18 06:17:14 UTC
Works fine. 
QA tool complains about a forbidden pattern tab char, opac/opac-suggestions.pl (line 136)
Comment 4 Katrin Fischer 2018-06-10 10:56:40 UTC
Nick, did you forget about this one? :)
Comment 5 Nick Clemens (kidclamp) 2018-06-16 02:07:24 UTC
Seems to be fixed