Dear Developers, We would like to see export feature (csv format) book suggestions for approval in staff client. In many libraries, Director of the institution want to see the list of suggested books by library users before placing order. He/she would suggest to remove books from list. This feature is useful to get the list of books for approval via OPAC and send to concerned authority before finalization.
Wouldn't this make more sense as a feature in the staff client?
(In reply to Owen Leonard from comment #1) > Wouldn't this make more sense as a feature in the staff client? Right
(In reply to vimal kumar from comment #2) > (In reply to Owen Leonard from comment #1) > > Wouldn't this make more sense as a feature in the staff client? > > Right I agree with your suggestion.
Maybe we could add the table configuration with the new export options to the suggestions table. That could solve multiple issues at once.
Created attachment 97293 [details] [review] Bug 16784: Add table configuration on suggestions table This patch adds DataTables column configuration and export options to the suggestions management tables in the staff interface. The columns settings made via the administrative interface will affect tables under each tab in the interface whether it be organized by status, library, etc. However because of the way the KohaTable function is currently written, changes made via the "Columns" button will only affect the visible table. To test, apply the patch and go to Acquisitions -> Suggestions. - Under each tab, the table of suggestions should have a DataTables toolbar with export and columns buttons. These controls should work correctly: - Showing and hiding columns should work as expected - Exports should work, excluding the first and last columns - Test the tables when using the various "Organize by" settings. - Test changing the settings in Administration -> Columns settings. - Verify that the changes you make to that configuration are reflected in the suggestions tables.
Created attachment 97295 [details] [review] Bug 16784: Add table configuration on suggestions table This patch adds DataTables column configuration and export options to the suggestions management tables in the staff interface. The columns settings made via the administrative interface will affect tables under each tab in the interface whether it be organized by status, library, etc. However because of the way the KohaTable function is currently written, changes made via the "Columns" button will only affect the visible table. To test, apply the patch and go to Acquisitions -> Suggestions. - Under each tab, the table of suggestions should have a DataTables toolbar with export and columns buttons. These controls should work correctly: - Showing and hiding columns should work as expected - Exports should work, excluding the first and last columns - Test the tables when using the various "Organize by" settings. - Test changing the settings in Administration -> Columns settings. - Verify that the changes you make to that configuration are reflected in the suggestions tables. Signed-off-by: David Nind <david@davidnind.com>
Hi Owen, can you check this fail from the QA tools please? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt FAIL filters missing_filter at line 841 ( KohaTable("[% suggestion.suggestiontype %]t", {) I am not friendly with the datatables yet, so didn't want to break things.
Created attachment 97408 [details] [review] Bug 16784: (follow-up) Add missing filter This follow-up adds a missing template filter quiet qa tool warning.
Created attachment 97418 [details] [review] Bug 16784: Add table configuration on suggestions table This patch adds DataTables column configuration and export options to the suggestions management tables in the staff interface. The columns settings made via the administrative interface will affect tables under each tab in the interface whether it be organized by status, library, etc. However because of the way the KohaTable function is currently written, changes made via the "Columns" button will only affect the visible table. To test, apply the patch and go to Acquisitions -> Suggestions. - Under each tab, the table of suggestions should have a DataTables toolbar with export and columns buttons. These controls should work correctly: - Showing and hiding columns should work as expected - Exports should work, excluding the first and last columns - Test the tables when using the various "Organize by" settings. - Test changing the settings in Administration -> Columns settings. - Verify that the changes you make to that configuration are reflected in the suggestions tables. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 97419 [details] [review] Bug 16784: (follow-up) Add missing filter This follow-up adds a missing template filter quiet qa tool warning. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Enhancement not backported to 19.11.x branch
*** Bug 26294 has been marked as a duplicate of this bug. ***