Bug 16792 - Add Font Awesome Icon and mini button to Keyword to MARC mapping section
Summary: Add Font Awesome Icon and mini button to Keyword to MARC mapping section
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Héctor Eduardo Castro Avalos
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 15801
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-21 19:22 UTC by Héctor Eduardo Castro Avalos
Modified: 2016-11-30 12:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 16792: Add Font Awesome Icon and mini button to Keyword to MARC mapping section (1.51 KB, patch)
2016-06-21 19:25 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 16792: Add Font Awesome Icon and mini button to Keyword to MARC mapping section (1.64 KB, patch)
2016-06-21 19:56 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 16792: Add Font Awesome Icon and mini button to Keyword to MARC mapping section (1.69 KB, patch)
2016-06-24 15:52 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Héctor Eduardo Castro Avalos 2016-06-21 19:22:47 UTC
Improve Admin > Keyword to MARC mapping to fit with others interfaces in Koha.

This bug change "Delete" link with a mini-button and introduce the trash icon.
Comment 1 Héctor Eduardo Castro Avalos 2016-06-21 19:25:45 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-06-21 19:56:18 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2016-06-24 15:52:53 UTC
Created attachment 52822 [details] [review]
Bug 16792: Add Font Awesome Icon and mini button to Keyword to MARC mapping section

Improve Admin > Keyword to MARC mapping to fit with others interfaces in Koha.
This bug change "Delete" link with a mini-button and introduce the trash icon.

To test:
-Apply patch
-Goto Admin > Keyword to MARC mapping
-Select one framework
-Add some mappings
-Notice about the new button with trash icon

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Kyle M Hall 2016-07-08 13:42:38 UTC
Passed QA but blocked by dependency.
Comment 5 Josef Moravec 2016-11-04 09:52:45 UTC
Patch from bug 15801 is now in master so marking Passed QA as Kyle stated

I retested it just to be 110% sure, patch applies cleanly and works as expected for me.
Comment 6 Kyle M Hall 2016-11-04 11:11:36 UTC
Pushed to master for 16.11, thanks Hector!
Comment 7 Mason James 2016-11-30 08:28:16 UTC
blocked by enhancement, passing for 16.05