Bug 16865 - Patron self registration: hiding branchcode gives error
Summary: Patron self registration: hiding branchcode gives error
Status: RESOLVED DUPLICATE of bug 17364
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 26568 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-07-06 18:38 UTC by Nicole C. Engard
Modified: 2023-07-10 20:50 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2016-07-06 18:38:19 UTC
If you add branchcode to PatronSelfRegistrationBorrowerUnwantedField then self registration fails silently.  The library and the user have no idea what happened. We should have an error and/or not let branchcode be added to that preference.
Comment 1 Mark Tompsett 2016-08-14 16:28:17 UTC
-- or add a default branch code? :)
Similar to bug 16892 that I did for the OAuth2 auto-register.
Comment 2 Jonathan Druart 2016-11-17 09:45:06 UTC
This is not critical, it's a configuration issue.
Comment 3 Katrin Fischer 2017-10-29 21:51:00 UTC
The problem is that when hiding the branchcode, which is desirable for singel branch libraries, the email disappears. And without the email the verification process breaks. 

Normal is ok, becuase you can have work around it, but would be nice to see fixed. I see no reason why there should be any link between hiding email and branch.

Also: altcontactnote can't be hidden... haven't investigated deeper yet.
Comment 4 Jonathan Druart 2017-10-30 14:47:13 UTC
Katrin, I do not understand. Which email are you talking about?
Comment 5 Katrin Fischer 2017-11-01 11:02:36 UTC
The primary email field in the form where you enter the patron data.
Comment 6 Katrin Fischer 2017-11-01 11:04:10 UTC
Sorry for all the typos in my previous comment. The system preference *unwanted*  takes the database column names from the borrowers table. When you enter 'branchcode' it will hide more fields, especially the primary email (email) field, which doesn't make sense.
Comment 7 Jonathan Druart 2017-11-02 11:20:59 UTC
I do not recreate, I have added "branchcode" to PatronSelfRegistrationBorrowerUnwantedField, when I go to opac-memberentry.pl I do not see the library entry and see "primary email" in the "contact information" part.
Comment 8 Katrin Fischer 2017-11-02 19:50:00 UTC
It's odd, I was testing in a 16.11.12. Will try to retest on master soon.
Comment 9 Katrin Fischer 2020-04-18 23:15:28 UTC
I retested this on master and couldn't replicate the 'disappearing email', but found another explosion:

Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88

PatronSelfRegistrationBorrowerUnwantedField: branchcode
PatronSelfRegistrationLibraryList: CPL (same with empty)

Maybe we should catch the error and at the same time add a note to the pref that branchcode should not be hidden? Not sure how we determine the branch for the patron if it is hidden. Maybe we could hide it, if there is only one entry (no more libraries configured, *LibraryList only has one entry)
Comment 10 Katrin Fischer 2020-10-17 15:16:50 UTC
*** Bug 26568 has been marked as a duplicate of this bug. ***
Comment 11 Emily Lamancusa 2023-07-10 20:50:43 UTC

*** This bug has been marked as a duplicate of bug 17364 ***