Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates
Summary: Remove the use of "onclick" from serial collection and serial edit templates
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 17858
  Show dependency treegraph
 
Reported: 2016-07-22 13:18 UTC by Owen Leonard
Modified: 2019-01-15 19:09 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates (20.52 KB, patch)
2016-07-22 14:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates (20.70 KB, patch)
2016-08-01 17:50 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates (20.72 KB, patch)
2016-08-02 10:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates (20.38 KB, patch)
2017-01-18 21:36 UTC, Gracie
Details | Diff | Splinter Review
Screenshot of formatting issue on serial collection page (10.88 KB, image/png)
2017-10-07 23:10 UTC, Katrin Fischer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-07-22 13:18:09 UTC
There are many uses of "onclick" and other event attributes in the Serials module templates. This bug will track changes to serials-collection.tt and serials-edit.tt
Comment 1 Owen Leonard 2016-07-22 14:23:22 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2016-08-01 17:50:54 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-08-02 10:27:35 UTC Comment hidden (obsolete)
Comment 4 Gracie 2017-01-18 21:32:48 UTC
While testing this bug I came across the fact that in the 'Add Item' form there are no repeatable fields, what "clone" button are you referring to?
Comment 5 Gracie 2017-01-18 21:36:15 UTC
Created attachment 59181 [details] [review]
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates

This patch removes the use of event attributes like "onclick" from the
serial collection and serial edit templates. Events are now defined in
JavaScript.

Also changed: Converted "create routing list," "edit routing list," and
"Renew" links to Bootstrap buttons. The "select all" and "clear all"
links have Font Awesome icons added.

To test, apply the patch and go to Serials

- Locate or create a subscription for which an item record is NOT
  created when receiving.
  - On the serial collection page for this subscription, test that the
    "Multi receiving" button works correctly.
- For any subscription, test that the "Generate next" button works
  correctly.
- In each tab, test that the "select all" and "clear all" links work
  correctly.
- On a subscription which has expired, test that the "Renew" button
  works correctly.
- On the serial collection page, select multiple issues and click the
  "Edit serials" button.
  - Testing with a subscription for which an item record is NOT created
    when receiving:
    - Changing the status to "Arrived" or "Claimed" should change the
      "Expected on" date to today's date. Selecting any other status
      should leave the "expected on" date as it was or return it to its
      original value.
    - Test that the "Multi receiving" button works correctly.
  - Testing with a subscription for which an item record IS created when
    receiving:
    - Changing the status of an issue should work as above but should
      also trigger the appearance of the item add form when the status
      is "Arrived" or "Claimed," and hide the form otherwise.
    - Cliking the "Item" link at the top of the item add form should
      hide it.
    - Clicking the "Add item" link under any issue should display the
      item add form.
    - In the item add form, test that repeatable fields are correctly
      duplicated when you click the "clone" button.
    - On the "Supplemental issue" line, changing the status to "Arrived"
      should work as described above. Changing the status on this line
      to "Claimed" should only change the "Expected on" date.
    - Adding regular and supplemental issues should work correctly.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Works as described.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Katrin Fischer 2017-10-07 23:10:53 UTC
Created attachment 67814 [details]
Screenshot of formatting issue on serial collection page

There is a tiny issue with the table heading on the serials collection page, when a subscription is renewed.