Bug 17139 - Translation process should not pick class value inside span tags
Summary: Translation process should not pick class value inside span tags
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-17 14:45 UTC by Marc Véron
Modified: 2017-12-07 22:16 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-08-17 14:45:26 UTC
Example:

koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
line 14:
 <span class="BT">

BT is picked for translation
Comment 1 Marc Véron 2016-08-17 14:57:49 UTC
...but we have:

<span class="UF"><abbr title="Used For">


Inside abbr tag, "Used For" should be translatable (is picked by translation process).
Comment 2 Marc Véron 2017-05-28 06:28:38 UTC
(In reply to Marc Véron from comment #0)
> Example:
> 
> koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
> line 14:
>  <span class="BT">
> 
> BT is picked for translation

Tested in current translation, it is not picked from span tag.
Comment 3 Marc Véron 2017-05-28 06:50:31 UTC
(In reply to Marc Véron from comment #1)
> ...but we have:
> <span class="UF"><abbr title="Used For">
> 
> Inside abbr tag, "Used For" should be translatable (is picked by translation
> process).

Tested in current translation. The text is picked and is properly translated.
Example for manage-marc-import.tt

English:
<abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr>

German:
<abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr>

Minor issue: The lang tag remains "en", here it should be "de" for German.

IMO the lang tag could be removed because the language is declared at the top of the page:
<html lang="de-DE">
Comment 4 Marc Véron 2017-05-28 07:31:19 UTC
Setting to RESOLVED INVALID for comments #2 and #3
Issue with lang attribute in abbr tag goes to new bug 18687