Bug 17166 - OPAC suggestion form: making Title a required field to remove onclick Check function
Summary: OPAC suggestion form: making Title a required field to remove onclick Check f...
Status: RESOLVED DUPLICATE of bug 10848
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 03:49 UTC by Aleisha Amohia
Modified: 2016-09-09 17:33 UTC (History)
0 users

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 17166: OPAC suggestion form: Make Title a required field (3.53 KB, patch)
2016-08-23 03:51 UTC, Aleisha Amohia 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-08-23 03:49:22 UTC 
Currently we have an onclick function that checks if anything has been entered in Title before submitting. Using the built-in required attribute makes this unnecessary
Comment 1 Aleisha Amohia 2016-08-23 03:51:48 UTC 
Created attachment 54741 [details] [review]
Bug 17166: OPAC suggestion form: Make Title a required field

To test:
1) Log in to OPAC
2) Go to your suggestions
3) New suggestion
4) Attempt to submit a suggestion without the title
5) Notice pop-up error box
6) Apply patch and refresh page
7) Attempt to submit a suggestion without the title
8) Notice error bubble and form cannot submit

Sponsored-by: Catalyst IT
Comment 2 Katrin Fischer 2016-08-23 05:44:42 UTC 
Hi Aleisha, I tested bug 10848 some days ago, it's currently waiting to get pushed. Haven't tested, but it might make this patch obsolete.
Comment 3 Aleisha Amohia 2016-08-23 22:52:04 UTC 
(In reply to Katrin Fischer from comment #2)
> Hi Aleisha, I tested bug 10848 some days ago, it's currently waiting to get
> pushed. Haven't tested, but it might make this patch obsolete.

True! When that gets pushed, this can be marked a duplicate of that
Comment 4 Owen Leonard 2016-09-09 17:33:34 UTC 

*** This bug has been marked as a duplicate of bug 10848 ***