When checking an item out through SIP and the item has hit it's renewal limit, Koha responds with "Item has reached maximum renewals", but when renewing an item through SIP and the item has hit it's renewal limit, Koha responds with "NO_MORE_RENEWALS: 1 ". It doesn't make sense that there are different responses for essentially the same thing, even though in this case it is technically two different processes. Also, the number 1 seems to have no purpose. I increased the number of renewals, and this number doesn't change, so I don't know what it is supposed to be indicating. This makes trapping renewal limits more tedious. I would recommend the following changes to these responses. 1. Have the checkout and renewal processes through SIP respond with the same "Item has reached maximum renewals." 2. Note the period added to the end of the response. 3. Note the removal of the space at the end of the renewal response.
Since renewals can be blocked by holds, I'll revise my wish list here: 1. Have the checkout and renewal processes through SIP respond with the same "Item cannot be renewed." 2. Note the period added to the end of the response. 3. Note the removal of the space at the end of the renewal response. 4. The remainder of responses should be reviewed for punctuation and stray spaces.
If there is a way to have the messages be more specific about the blocks, such as renewal limit reached or hold on the item, a more specific response would be considered, but the response should be the same whether through the renew process or the checkout process.