Edifact::Line 's quantity method is currently used in the context of receipting from an invoice, but the line object only looks at tag in populating the value. It should check the quantity qualifier to ensure that another type of quantity is not being incorrectly returned. The method should be renamed to be more specific e.g. invoiced_quantity rather than quantity, in order to self document
Created attachment 55344 [details] [review] Proposed Patch Tests added to Edifact.t and EdiInvoice.t to ensure correct values returned Realised the need when only one copy of 6 got receipted at a site because invoice included multiple delivery instructions (each with a qty of 1)
How should this be tested?
(In reply to Owen Leonard from comment #2) > How should this be tested? The unit tests check that the two fields are now being returned separately as expected. Previously they were not distinguished.
Should this be FAILED QA?
Distinction is maintained by code in patch 18267 which incorporates tests from this *** This bug has been marked as a duplicate of bug 18267 ***