Bug 17295 - Missed variable removal in subscription-add.pl from Bug 15758
Summary: Missed variable removal in subscription-add.pl from Bug 15758
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 15758
Blocks:
  Show dependency treegraph
 
Reported: 2016-09-13 14:09 UTC by Nick Clemens
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17295 - Missed variable removal in subscription-add.pl from Bug 15758 (1.06 KB, patch)
2016-09-13 14:11 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 17295 - Missed variable removal in subscription-add.pl from Bug 15758 (1.13 KB, patch)
2016-09-13 14:48 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2016-09-13 14:09:42 UTC
stray '$branchloop' variable left in perl file
Comment 1 Nick Clemens 2016-09-13 14:11:11 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-09-13 14:48:35 UTC
Created attachment 55541 [details] [review]
Bug 17295 - Missed variable removal in subscription-add.pl from Bug 15758

To test:
Load subscription-add.pl
Get an error
Apply patch
Reload
Koha is less sad (page loads okay)
Verify that normal functions work

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2016-09-13 14:48:57 UTC
Trivial, skipping QA.
Thanks Nick!
Comment 4 Kyle M Hall 2016-09-13 18:12:46 UTC
Pushed to master for 16.11, thanks Nick!