Bug 1731 - MARC detail screen doesn't know record has no items/isn't for loan
Summary: MARC detail screen doesn't know record has no items/isn't for loan
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P3 normal (vote)
Assignee: Paul Poulain
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-02 11:46 UTC by Owen Leonard
Modified: 2012-10-25 23:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch submitted by Paul Poulain on 2009-04-19 (6.53 KB, patch)
2010-06-03 14:32 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:33:57 UTC


---- Reported by oleonard@myacpl.org 2008-01-02 11:46:56 ----

The "place hold" button is hidden in detail.pl when there are no items or the items are not for loan. MARC detail should do the same.



---- Additional Comments From gmcharlt@gmail.com 2009-04-19 13:12:25 ----

Patch pushed to HEAD.  Please test and close.



---- Additional Comments From oleonard@myacpl.org 2009-10-07 20:16:42 ----

I'm still seeing this bug in an up-to-date installation.



---- Additional Comments From nengard@gmail.com 2009-12-17 00:41:57 ----

I too am still seeing it on the most recent HEAD



---- Additional Comments From nengard@gmail.com 2010-05-14 11:34:43 ----

Just an update - this is still an issue



---- Additional Comments From nengard@gmail.com 2010-05-14 11:38:22 ----

I looked at the templates but can't
figure it out on my own.




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:33 UTC  ---

This bug was previously known as _bug_ 1731 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1731

Actual time not defined. Setting to 0.0

Comment 1 Owen Leonard 2010-06-03 14:32:22 UTC
Created attachment 2210 [details] [review]
Patch submitted by Paul Poulain on 2009-04-19
Comment 2 Owen Leonard 2010-06-03 14:34:51 UTC
I've attached the patch message from the patches mailing list since none was attached to this bug. However, I'm removing the patch-sent status since the patch doesn't seem to have fixed the problem.
Comment 3 Owen Leonard 2010-08-27 18:57:40 UTC
Testing again and it does seem to be working. I've got no "place hold" button if items have "not for loan" set, if there are no items, or if the item type is not for loan.

Can someone else confirm?
Comment 4 Paul Poulain 2011-08-02 10:21:13 UTC
Yes, I confirm it works now.