Bug 17328 - Koha fixes for Mysql 5.7
Summary: Koha fixes for Mysql 5.7
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic record staging/import (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Blou
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 17258
  Show dependency treegraph
 
Reported: 2016-09-22 13:32 UTC by Blou
Modified: 2018-02-07 21:14 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17328 - import_records.marcxml_old requires a value (1.35 KB, patch)
2016-09-22 14:04 UTC, Blou
Details | Diff | Splinter Review
Bug 17328 - borrowers.flags must be passed an integer. (901 bytes, patch)
2016-09-22 14:07 UTC, Blou
Details | Diff | Splinter Review
Bug 17328 - categories' many int fields cannot be NULL (1.77 KB, patch)
2016-09-22 14:27 UTC, Blou
Details | Diff | Splinter Review
Bug 17328 - borrowers.flags must be passed an integer. (885 bytes, patch)
2016-09-22 14:32 UTC, Blou
Details | Diff | Splinter Review
Bug 17328 - Borrowers table modifications must provide valid values for int columns (1.74 KB, patch)
2016-09-27 13:17 UTC, Blou
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Blou 2016-09-22 13:32:32 UTC
I'm accruing many little issues. while running the code.  I'll put the patches in, at least to document them.  If the powers-that-be decide to fix in differently, all the same to me.
Comment 1 Blou 2016-09-22 14:04:22 UTC
Created attachment 55748 [details] [review]
Bug 17328 - import_records.marcxml_old requires a value

https://bugs.koha-community.org/show_bug.cgi?id=17238
Comment 2 Blou 2016-09-22 14:07:26 UTC
Created attachment 55749 [details] [review]
Bug 17328 - borrowers.flags must be passed an integer.
Comment 3 Blou 2016-09-22 14:27:12 UTC
Created attachment 55751 [details] [review]
Bug 17328 - categories' many int fields cannot be NULL

This fixes the code, but the DB should also be fixed with default values.
Comment 4 Zeno Tajoli 2016-09-22 14:30:05 UTC
Connect to the general bug 17258
Comment 5 Blou 2016-09-22 14:32:51 UTC
Created attachment 55752 [details] [review]
Bug 17328 - borrowers.flags must be passed an integer.
Comment 6 Blou 2016-09-27 13:17:11 UTC
Created attachment 55841 [details] [review]
Bug 17328 - Borrowers table modifications must provide valid values for int columns
Comment 7 Blou 2016-09-27 13:18:08 UTC
Comment on attachment 55752 [details] [review]
Bug 17328 - borrowers.flags must be passed an integer.

now cover the other fields from table borrowers.
Comment 8 Blou 2016-09-27 13:46:40 UTC
too... many... issues... Now fighint le size limit on issn.

All of this pointless unless first patching the DB with alters to set default values, then modify the schemas, then modify the code.  Huge task...