When using the quick add feature it's not possible to add a guarantor. To test: - Use quick add form to add a "Kid" (sample patron category) - "Set patron" and search for a patron to link with - Click "choose" - Verify that the guarantor fields in the form remain empty - Open 'full form' - notice some information is there
I think we should try and fix this fast, as quick add is a prominent feature in the new release.
Working on this, but I have a question: Guarantor form also adds some address info - Would it be enough to add note to quick add form that this info will be added/saved and to see full form to edit - or should we make these fields (streetnumber, address,address2, city,state,zipcode,country,branchcode) displayed by default on a form with guarantor selector? (In reply to Katrin Fischer from comment #1) > I think we should try and fix this fast, as quick add is a prominent feature > in the new release.
What about if we simply remove the support of guarantor for the quick add form?
Hm, I wouldn't display by default, a note would work for me. I am not sure how hard it is to do, but we put some time and effort in to make it work for guarantors, so not sure we should remove it right away.
Created attachment 57674 [details] [review] Bug 17344 - Can't set guarantor in quick add brief form This patch updates the guarantor form to work with the quick add form To test: 1 - Quick add a 'Kid' patron (or other patron type that may have guarantor) 2 - Verify form appears as expected 3 - Test that you can add a patron manually or using selector 4 - Test that deletion works as expected 5 - Test 3 and 4 from the full version of the form 6 - Save or cancel and add a new patron using the full form only 7 - Verify that adding/deleting guarantor works with no errors 8 - Sign off
Created attachment 57678 [details] [review] [SIGNED-OFF] Bug 17344 - Can't set guarantor in quick add brief form This patch updates the guarantor form to work with the quick add form To test: 1 - Quick add a 'Kid' patron (or other patron type that may have guarantor) 2 - Verify form appears as expected 3 - Test that you can add a patron manually or using selector 4 - Test that deletion works as expected 5 - Test 3 and 4 from the full version of the form 6 - Save or cancel and add a new patron using the full form only 7 - Verify that adding/deleting guarantor works with no errors 8 - Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Nick, At several places you are using a "quick_add_form" selector, this does not look right. As you are using the id (#) you should not need to specify anything else.
It is a consequence of cloning the fields, there are doubled ids. I am open to suggestions but this was the easy/fast way to repair this part of the feature. (In reply to Jonathan Druart from comment #7) > Nick, > At several places you are using a "quick_add_form" selector, this does not > look right. > As you are using the id (#) you should not need to specify anything else.
Created attachment 57705 [details] [review] Bug 17344 - Followup to fix selectors Add '#' selector to several tags Fix some spacing Remove duplicated line To highlight that all is working set PatronQuickAddFields as below for testing: streetnumber|address|address2|city|state|zipcode|country|branchcode
I don't think we need "#quick_add_form #streetnumber" as a selector, "#streetnumber" should be enough.
Created attachment 57708 [details] [review] Bug 17344 - Can't set guarantor in quick add brief form This patch updates the guarantor form to work with the quick add form To test: 1 - Quick add a 'Kid' patron (or other patron type that may have guarantor) 2 - Verify form appears as expected 3 - Test that you can add a patron manually or using selector 4 - Test that deletion works as expected 5 - Test 3 and 4 from the full version of the form 6 - Save or cancel and add a new patron using the full form only 7 - Verify that adding/deleting guarantor works with no errors 8 - Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 57709 [details] [review] Bug 17344 - Followup to fix selectors Add '#' selector to several tags Fix some spacing Remove duplicated line To highlight that all is working set PatronQuickAddFields as below for testing: streetnumber|address|address2|city|state|zipcode|country|branchcode Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Note that some things should be rewritten here. We should not have 2 elements with the same id at the same time in the DOM, this is semantically wrong.
(In reply to Jonathan Druart from comment #13) > Note that some things should be rewritten here. > We should not have 2 elements with the same id at the same time in the DOM, > this is semantically wrong. It also makes jQuery grumpy - you can't select using the id then in my experience. We have some other places in acq where this happens or happened.
Pushed to master for 17.05! Thanks Nick!
This patch has been pushed to 16.11.x, will be in 16.11.01!