Bug 17399 - SIP2 Screen messages for checkout failure should be improved
Summary: SIP2 Screen messages for checkout failure should be improved
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-04 15:53 UTC by Nick Clemens (kidclamp)
Modified: 2016-10-04 15:53 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2016-10-04 15:53:46 UTC
Koha should return useful screen messages for patrons when a checkout fails for some reason, currently it seems we just get the last kye/value pair:

In C4 / SIP / ILS / Transaction / Checkout.pm

Line 69 is quite correct:

  67     if (scalar keys %$issuingimpossible) {
  68         foreach (keys %$issuingimpossible) {
  69             # do something here so we pass these errors
  70             $self->screen_msg($_ . ': ' . $issuingimpossible->{$_});
  71             $noerror = 0;
  72         }
  73     }