Created attachment 56058 [details] Remove current_framework. When viewing a biblio the url generated for editing generated is with the parameters: current_framework that is not initialized anywhere. I remove it from the call edit record and Edit as new (duplicate).
Created attachment 56083 [details] [review] Bug 17405 - The creation of the url on cat-toolbar.inc is using obsolete current_framework When viewing a biblio the url generated for editing generated is with the parameters: current_framework that is not initialized anywhere. This patch removes the parameter because it is not necessary To test, apply the patch and view the detail page for a bibliographic record which uses a framework other than the default. Test that the "Edit" and "Edit as new (duplicate)" loads the MARC editor using the correct framework.
Rodrigo, I took the attachment you posted and formatted it as a patch. There is information on the wiki about how to create patches: https://wiki.koha-community.org/wiki/Version_Control_Using_Git#Doing_work_on_Koha_with_Git Take a look and feel free to ask questions if you need help.
Created attachment 56234 [details] [review] Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Added a test plan
Created attachment 56564 [details] [review] [SIGNED-OFF]Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Added a test plan Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Fix the issue, no errors.
Created attachment 56626 [details] [review] Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Added a test plan Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Fix the issue, no errors. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Rodrigo!
Pushed in 16.05. Will be in 16.05.05.
Pushed in 3.22.x, will be in 3.22.12