Bug 17438 - Warnings from Business::ISBN::Data in webinstaller
Summary: Warnings from Business::ISBN::Data in webinstaller
Status: RESOLVED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-13 10:37 UTC by Marcel de Rooy
Modified: 2023-06-25 13:48 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Facing problem while upgrading from koha 18 to 21 (26.76 KB, image/png)
2022-10-24 11:31 UTC, shalini
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2016-10-13 10:37:50 UTC
Upgrading to 16.06.00.032 I saw these warnings in the webinstaller:

    [Thu Oct 13 11:57:17 2016] Data.pm: ISBN_RANGE_MESSAGE is set to [] but that file does not exist!
    [Thu Oct 13 11:57:17 2016] Data.pm: Trying to use the default locations
    [Thu Oct 13 11:57:17 2016] Data.pm: at /usr/share/perl5/Business/ISBN.pm line 76.

Related to the version of libbusiness-isbn-data-perl in Jessie.
Comment 1 Jonathan Druart 2016-11-17 09:30:29 UTC
Could you give us more details please?
Which version of Business::ISBN? Did you find which Koha version gives this warning?
Comment 2 Marcel de Rooy 2016-11-17 09:45:40 UTC
(In reply to Jonathan Druart from comment #1)
> Could you give us more details please?
> Which version of Business::ISBN? Did you find which Koha version gives this
> warning?

Must have been 2.09 (Jessie).
This was about an upgrade from master 16.06.00.??? to master 16.06.00.032.
Comment 3 Marc Véron 2017-05-10 03:43:03 UTC
I got the same while upgrading to the newest master 16.12.00.032
Perl modules on aobut page: Business::ISBN (2.05) 	2.09 


    [Wed May 10 05:33:06 2017] updatedatabase.pl: ISBN_RANGE_MESSAGE is set to [] but that file does not exist!
    [Wed May 10 05:33:06 2017] updatedatabase.pl: Trying to use the default locations
    [Wed May 10 05:33:06 2017] updatedatabase.pl: at /usr/share/perl5/Business/ISBN.pm line 76.
Comment 4 Marc Véron 2017-08-03 14:53:01 UTC
Reproduced while updating an older VM from 16.12.00.22 to 17.06.00.003, same result as in comment #3 (update to 16.12.00.032)

Business::ISBN was 2.09

Restored VM, updated Business:ISBN to 3.004, installed Business::Data, then tried again, same result.

Update to 16.12.00.032 is related to Bug 12063 - Update reserves.expirationdate

16.12.00.032 is in updatedatabase.pl line 14354 following.
Comment 5 Doug Dearden 2020-11-18 21:49:25 UTC
I got the same error messages during an update from 19.05.10 to 19.15.16
Comment 6 Doug Dearden 2020-11-18 21:53:29 UTC
(In reply to Doug Dearden from comment #5)
> I got the same error messages during an update from 19.05.10 to 19.05.16
Comment 7 Jonathan Druart 2020-11-19 09:41:05 UTC
(In reply to Doug Dearden from comment #6)
> (In reply to Doug Dearden from comment #5)
> > I got the same error messages during an update from 19.05.10 to 19.05.16

Which errors?
Can you post the upgrade logs?

I don't see anything related to ISBN between 19.05.10 and 19.05.16
Comment 8 Doug Dearden 2020-11-19 18:52:48 UTC
Updatedatabase log
Upgrade to 19.05.10.001 done (Bug 20754: Remove double accepted list shares)
Upgrade to 19.05.10.002 done (Bug 23081: Set default to 0 for items.issues)
Upgrade to 19.05.10.003 done (Bug 25184: Items with a negative notforloan status should not be captured for holds)
Upgrade to 19.05.11.000 done (19.05.11 release)
Upgrade to 19.05.11.001 done (Bug 24854 - Disable IDreamBooks)
Upgrade to 19.05.11.002 done (Replay of 19.05.10.003 upgrade - that initially had a typo - to ensure the changes are done)
Upgrade to 19.05.12.000 done (19.05.12 release)
Upgrade to 19.05.12.001 done (Bug 24986 - Switch borrowers address related fields to TINYTEXT or MEDIUMTEXT)
Upgrade to 19.05.13.000 done (19.05.13 release)
Upgrade to 19.05.14.000 done (19.05.14 release)
Upgrade to 19.05.14.001 done (Bug 25709 - Rename systempreference to NotesToHide)
Upgrade to 19.05.14.002 done (Bug 24379 - Set login_attempts NOT NULL)
Upgrade to 19.05.15.000 done (19.05.15 release)
Upgrade to 19.05.16.000 done (19.05.16 release)

Updatedatabase-error log
[Wed Nov 18 13:16:19 2020] Data.pm: ISBN_RANGE_MESSAGE is set to [] but that file does not exist!
[Wed Nov 18 13:16:19 2020] Data.pm: Trying to use the default locations
[Wed Nov 18 13:16:19 2020] Data.pm:  at /usr/share/perl5/Business/ISBN.pm line 76.
Comment 9 Jonathan Druart 2020-11-20 07:49:57 UTC
(In reply to Doug Dearden from comment #8)
> [Wed Nov 18 13:16:19 2020] Data.pm: ISBN_RANGE_MESSAGE is set to [] but that
> file does not exist!
> [Wed Nov 18 13:16:19 2020] Data.pm: Trying to use the default locations
> [Wed Nov 18 13:16:19 2020] Data.pm:  at /usr/share/perl5/Business/ISBN.pm
> line 76.

This error is displayed by an external module when the environment variable ISBN_RANGE_MESSAGE is set. In your case it's defined but set to an empty string.

Are you on Jessie?
Comment 10 Doug Dearden 2020-11-20 17:27:26 UTC
No, on stretch

Distributor ID: Debian
Description:    Debian GNU/Linux 9.13 (stretch)
Release:        9.13
Codename:       stretch

When I issue a printenv command I don't see this environment variable.  I didn't find it in the koha-conf.xml either.
Comment 11 Jonathan Druart 2020-11-24 08:51:53 UTC
I would not worry about it if it only appears once.
Comment 12 shalini 2022-10-24 11:31:45 UTC
Created attachment 142488 [details]
Facing problem while upgrading from koha 18 to 21

I am trying to upgrade koha from 18 to 21. When I try to upgrade the schema it doesn't go past 19.06.00.005.
It throws the following error:
Update errors :

ISBN_RANGE_MESSAGE is set to [] but that file does not exist!
Trying to use the default locations
at /usr/share/perl5/Business/ISBN.pm line 87.
Can't use string ("- id: 165
selector: #coverflo"...) as an ARRAY ref while "strict refs" in use at /var/lib/koha/library/plugins/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm line 377.

Can someone help?
Comment 13 Katrin Fischer 2022-10-24 11:34:44 UTC
(In reply to shalini from comment #12)
> Created attachment 142488 [details]
> Facing problem while upgrading from koha 18 to 21
> 
> I am trying to upgrade koha from 18 to 21. When I try to upgrade the schema
> it doesn't go past 19.06.00.005.
> It throws the following error:
> Update errors :
> 
> ISBN_RANGE_MESSAGE is set to [] but that file does not exist!
> Trying to use the default locations
> at /usr/share/perl5/Business/ISBN.pm line 87.
> Can't use string ("- id: 165
> selector: #coverflo"...) as an ARRAY ref while "strict refs" in use at
> /var/lib/koha/library/plugins/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm
> line 377.
> 
> Can someone help?

Please try the mailing list or IRC and also include the full version numbers. There are 18.05, 18.11 and 21.05 and 21.11 - each with various bugfix releases too.
Comment 14 shalini 2022-10-24 17:06:31 UTC
Koha18.05.04.000 -Koha21.05

Thank you so much. I have sent the msg to the mailing list.
Comment 15 Katrin Fischer 2023-06-25 13:48:18 UTC
This bug was reported against versions that are no longer maintained (19.05 and earlier). I am marking WONTFIX, please reopen if you disagree.