Bug 17475 - 'Edition' tab in detail.pl fails to display records with matching ISBNs
Summary: 'Edition' tab in detail.pl fails to display records with matching ISBNs
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Mason James
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-20 09:22 UTC by Mason James
Modified: 2016-12-16 19:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
example of bib with missing 'editions' tab (85.15 KB, image/png)
2016-10-21 05:05 UTC, Mason James 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2016-10-20 09:22:18 UTC 
mroe info to come...
Comment 1 Mason James 2016-10-21 05:02:52 UTC 
Take 3 bibs, with these isbns...

bib1 = 9780802806017; 9780802871855; 9780802827876
bib2 = 9780802871855
bib3 = 9780802827876

The Edition/FRBR matching code should successfully match all 3 bibs, but currently this does not happen :'(


There seems to be 2 bugs with the code, that cause incomplete matching in some edge-cases

Bug 1: Records with ISBN13 values don't match correctly

All isbns13 values are converted to isbn10 format for matching, then matched against isbn13 database values (in some cases). This causes some records not to be successfully matched


Bug 2: Records with multiple ISBN values don't match correctly

For records with multiple ISBN value, only the isbn10 value of the 1st ISBN subfield is used for matching, all other ISBN subfields are ignored. This causes some records not to be successfully matched


also, note that all ISBNs in all 3 bibs match successfully at librarything

http://www.librarything.com/api/thingISBN/9780802806017
http://www.librarything.com/api/thingISBN/9780802871855
http://www.librarything.com/api/thingISBN/9780802827876


<idlist>
<isbn>080282787X</isbn>
<isbn>0802806015</isbn>
<isbn>0802871852</isbn>
<isbn>080283695X</isbn>
</idlist>
Comment 2 Mason James 2016-10-21 05:05:32 UTC 
Created attachment 56712 [details]
example of bib with missing 'editions' tab