Bug 17564 - Acquisition/OrderUsers.t is broken
Summary: Acquisition/OrderUsers.t is broken
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 13321
Blocks: 13726
  Show dependency treegraph
 
Reported: 2016-11-07 11:09 UTC by Jonathan Druart
Modified: 2016-12-14 10:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t (2.60 KB, patch)
2016-11-07 11:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t (2.67 KB, patch)
2016-11-07 11:38 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t (2.71 KB, patch)
2016-11-08 19:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-11-07 11:09:30 UTC

    
Comment 1 Jonathan Druart 2016-11-07 11:09:59 UTC
Caused by bug 13321 (test file added after the first submission).
Comment 2 Jonathan Druart 2016-11-07 11:11:49 UTC
Created attachment 57252 [details] [review]
Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t

ModReceiveOrder takes now a 'order' parameter and is mandatory.
This new test file has been added after the first submission of bug
13321 and has not been updated during the rebases.

Test plan:
  prove t/db_dependent/Acquisition/OrderUsers.t
should return green
Comment 3 Josef Moravec 2016-11-07 11:38:16 UTC
Created attachment 57255 [details] [review]
[SIGNED-OFF] Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t

ModReceiveOrder takes now a 'order' parameter and is mandatory.
This new test file has been added after the first submission of bug
13321 and has not been updated during the rebases.

Test plan:
  prove t/db_dependent/Acquisition/OrderUsers.t
should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Tomás Cohen Arazi 2016-11-08 19:18:31 UTC
Created attachment 57348 [details] [review]
Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t

ModReceiveOrder takes now a 'order' parameter and is mandatory.
This new test file has been added after the first submission of bug
13321 and has not been updated during the rebases.

Test plan:
  prove t/db_dependent/Acquisition/OrderUsers.t
should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Kyle M Hall 2016-11-10 13:36:25 UTC
Pushed to master for 16.11, thanks Jonathan!
Comment 6 Mason James 2016-12-14 10:30:50 UTC
Blocked by enhancement, skipping for 16.05.x