It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script.
Created attachment 57437 [details] [review] Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked!
Created attachment 57438 [details] [review] Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked!
Created attachment 57439 [details] [review] Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked!
Created attachment 57490 [details] [review] Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com>
Can we better put that info on a specific file? Maybe /etc/koha/sites/<instance>/plack.conf
I'm curious, but why add a separate config file for what amounts to a couple of lines? Why not just put them on koha-conf.xml? We desperately need this patch. We're running dozens of sites on our clusters, and need to be able to set different numbers of plack workers for different sites. Plus there are the larger sites on stand-alone servers, that need more than 2 workers, but when we change them in koha-plack, it gets overwritten with every upgrade. This is, in my opinion, a very needed patch.
(In reply to Tomás Cohen Arazi from comment #5) > Can we better put that info on a specific file? Maybe > /etc/koha/sites/<instance>/plack.conf Is that the only reason for Failed QA? I agree with Larry that they could be in koha-conf, just like similar stuff.
I think we could use this for now, and removed it later.
(In reply to Tomás Cohen Arazi from comment #8) > I think we could use this for now, and removed it later. Back to NSO
Created attachment 59377 [details] [review] Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Rebased against master and added a description for the new configuration entries
Created attachment 59680 [details] [review] Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Rebased against master and added a description for the new configuration entries Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 17.05!
This won't get ported back to 16.11.x as it is an enhancement.
I would love to see this backported to 16.11 as it would help many installations that still use 16.11 (such as ours). Although this feature is an enhancement, it doesn't conflict with any existing functionality. Also, I see that sometimes Koha get enhancement in its point release. For example, 16.11.08 has a new dev_install.
(In reply to Pongtawat from comment #14) > I would love to see this backported to 16.11 as it would help many > installations that still use 16.11 (such as ours). Although this feature is > an enhancement, it doesn't conflict with any existing functionality. > > Also, I see that sometimes Koha get enhancement in its point release. For > example, 16.11.08 has a new dev_install. You should PM Katrin, or contact her on IRC.
I just checked, this patch doesn't apply on 16.11.x and I am not confident in fixing the conflicts myself. I am not against backporting this, but need a patch for 16.11.x that is well tested.
Created attachment 64699 [details] [review] 16.11 - Allow the number of plack workers and max connections to be set in koha-conf.xml Backport to 16.11.x using current code in 17.05.x
Here is my take to backport this patch to 16.11. The code is a bit different than in the previous patch, as it was based on the code currently in 17.05.x branch. I think it need sign-off?
Thx Pongtawat. A sign-off would be great, I am changing the title and status.
No string changes, so this could still go into 16.11.10 if signed off on time.
Still willing to push this - can we get a sign-off?
Created attachment 68814 [details] [review] Bug 17610 - (16.11.x) Allow the number of plack workers and max connections to be set in koha-conf.xml Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Thank you for signing off. Now I see hope that this might get pushed into the next 16.11 update :)
Moving this one out of the SO queue
This has been pushed to 16.11.x and will be in 16.11.14.
Pushed to 16.05.x, for 16.05.19 release