Discovered when testing 13726 - count of subscriptions passed from supplier.pl to template, but template does not use it. Moreover, it would be useful to have even more information or at least count info + link to subscriptions on vendor profile page.
It is used in includes/acquisitions-toolbar.inc
(In reply to Jonathan Druart from comment #1) > It is used in includes/acquisitions-toolbar.inc Ah, I see, thanks. But still think that more detailed info about subscriptions could be useful on vendor page...
Created attachment 59137 [details] [review] Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details
I really like the idea! Looking at this from the view of translators, I'd like to make a suggestion: + <h2>Subscription Details</h2> + <p><strong>This vender has: </strong>[% subscriptioncount %] + [% IF subscriptioncount == 1 %] subscription [% ELSE %] subscriptions [% END %] + </p> + The h2 is cool, but capitalization should be: Subscription details The paragraph will be turned into 2 strings by the translation tools: - This vendor has - subscription subscriptions (with some additional markup %s in between) Strings show up out of context for translators and in alphabetical order - so that makes it really hard to 'get it right' - depending on the language it's also often hard to predict, what the right sequence of words/grammar should be like. My suggestion would be to make it: Number of subscriptions: [% subscriptioncount %]
Created attachment 59139 [details] [review] Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details
Created attachment 59178 [details] [review] [SIGNED OFF] Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed a missing </div>
Created attachment 59244 [details] [review] Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed a missing </div> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 59245 [details] [review] Bug 17691: Does not repeat "subscriptions" Number of subscriptions: X subscriptions Sound like we repeat "subscriptions" Replaced with Number of subscriptions: X Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master for 17.05, thanks Grace!
This won't get ported back to 16.11.x as it is an enhancement.