Created attachment 58003 [details] [review] Bug 17731: Remove noxml option from rebuild_zebra.pl The removal of the noxml is a logical follow-up of bug 16506 (which make xml the default). Actually this option should have been removed by bug 10455 (it removes the biblioitem.marc field). Test plan: Make sure the rebuild_zebra.pl script works as before.
Created attachment 59038 [details] [review] Bug 17731: Remove noxml option from rebuild_zebra.pl The removal of the noxml is a logical follow-up of bug 16506 (which make xml the default). Actually this option should have been removed by bug 10455 (it removes the biblioitem.marc field). Test plan: Make sure the rebuild_zebra.pl script works as before. Signed-off-by: Emma Smith <emma.nakamura.smith@gmail.com>
Created attachment 59238 [details] [review] Bug 17731: Remove noxml option from rebuild_zebra.pl The removal of the noxml is a logical follow-up of bug 16506 (which make xml the default). Actually this option should have been removed by bug 10455 (it removes the biblioitem.marc field). Test plan: Make sure the rebuild_zebra.pl script works as before. Signed-off-by: Emma Smith <emma.nakamura.smith@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.05, thanks Jonathan!
I think there is still some trace left of the -x: vagrant@kohadevbox:~$ sudo koha-rebuild-zebra -f kohadev Warning: You passed -x which is already the default and is now deprecated Waiting for feedback.
(In reply to Katrin Fischer from comment #5) > I think there is still some trace left of the -x: > > vagrant@kohadevbox:~$ sudo koha-rebuild-zebra -f kohadev > Warning: You passed -x which is already the default and is now deprecated > > Waiting for feedback. You are not using the patched scripts if you did not copy the debian scripts. sudo which koha-rebuild-zebra /usr/sbin/koha-rebuild-zebra
I will try that, thx!
I think the warning is not from outdated scripts, I have copied them, but old and newer koha-rebuild-zebra contain the following line: 98 opt_xml="-x" Which seems to trigger the message shown below for koha-rebuild-zebra?
Indeed! See bug 18069.
Ok, will take another look at this for 16.11.x
This patch has been pushed to 16.11.x and will be in 16.11.04.